Use actions queue when dispatching undo actions from "Release Actions" #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I actually missed that we also have to enqueue the retrieval of the |
whimboo
force-pushed
the
release-actions-dispatch
branch
2 times, most recently
from
0c2858c to
b1a5a4d
Compare
|
This PR should be ready for review now. Thanks. |
whimboo
commented
Oct 30, 2024
whimboo
force-pushed
the
release-actions-dispatch
branch
from
b1a5a4d to
20c5f83
Compare
whimboo
force-pushed
the
release-actions-dispatch
branch
from
20c5f83 to
8ebf35e
Compare
|
The current error in the Respec is actually caused by a missing |
whimboo
force-pushed
the
release-actions-dispatch
branch
from
8ebf35e to
c9e4151
Compare
jgraham
requested changes
Dec 3, 2024
Co-authored-by: jgraham <james@hoppipolla.co.uk>
whimboo
commented
Dec 3, 2024
Co-authored-by: jgraham <james@hoppipolla.co.uk>
Co-authored-by: jgraham <james@hoppipolla.co.uk>
|
@jgraham please check again. All suggestions have been applied. |
jgraham
approved these changes
Dec 5, 2024
github-actions bot
added a commit
to ZRDKPoWeR/webdriver
that referenced
this pull request
Dec 5, 2024
github-actions bot
added a commit
to soloinovator/webdriver
that referenced
this pull request
Dec 5, 2024
AtkinsSJ
reviewed
Jan 3, 2025
|
|
||
| <li><p>Dequeue <var>input state</var>'s <a>actions queue</a>. | ||
| <p>Assert: this returns <var>token</var> | ||
| <p>Assert: this returns <var>token</var> |
There was a problem hiding this comment.
Now that "wait for an action queue token" is a separate algorithm, there is no token variable here in "dispatch actions".
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 3, 2025
This reflects part of w3c/webdriver#1853
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 3, 2025
This reflects part of w3c/webdriver#1853 Also updated to reflect some minor spec text changes.
trflynn89
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Jan 3, 2025
This reflects part of w3c/webdriver#1853
trflynn89
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Jan 3, 2025
This reflects part of w3c/webdriver#1853 Also updated to reflect some minor spec text changes.
mikiubo
pushed a commit
to mikiubo/ladybird
that referenced
this pull request
Jan 4, 2025
This reflects part of w3c/webdriver#1853
mikiubo
pushed a commit
to mikiubo/ladybird
that referenced
this pull request
Jan 4, 2025
This reflects part of w3c/webdriver#1853 Also updated to reflect some minor spec text changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1837.
@jgraham could you please check? I hope that this is fine - it at least matches what we use in Firefox now when dispatching the actions from the parent process and it works fine. Thanks.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Dec 3, 2024, 3:19 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.