Correct specification of parallel operations #1431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, parallelism in the Execute Script and Execute Async Script commands was expressed in terms of ECMAScript promises. This was ambiguous because in HTML, Promises rely on an environment settings object [1], and such an object is not generally available in the WebDriver execution context. Refactor the command algorithms to instead manage parallel execution using the generic "queue" primitive from the Infra specification. Refactor the "execute a function body" algorithm to use Promises, where following the invocation of "prepare to run a script," an environment settings object is available. [1] https://html.spec.whatwg.org/#integration-with-the-javascript-job-queue
jugglinmike
requested review from
AutomatedTester,
jgraham and
shs96c
as code owners
|
We may want to hold off on this until there's consensus in gh-1436. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, parallelism in the Execute Script and Execute Async
Script commands was expressed in terms of ECMAScript promises. This was
ambiguous because in HTML, Promises rely on an environment settings
object [1], and such an object is not generally available in the
WebDriver execution context.
Refactor the command algorithms to instead manage parallel execution
using the generic "queue" primitive from the Infra specification.
Refactor the "execute a function body" algorithm to use Promises, where
following the invocation of "prepare to run a script," an environment
settings object is available.
[1] https://html.spec.whatwg.org/#integration-with-the-javascript-job-queue
Preview | Diff