-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting OK on confirm() is not considered a user gesture for permissions #736
Comments
Does this issue present in other browsers? |
It reproduces every time on Chrome, Edge and Brave. All at Chromium v131.
…On Thu, Dec 5, 2024 at 7:17 PM Simeon Vincent ***@***.***> wrote:
Does this issue present in other browsers?
—
Reply to this email directly, view it on GitHub
<#736 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJGK6KUP2FRAW3IDFG7MCT2EDULLAVCNFSM6AAAAABTDO5RF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRRG44TOMRZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I believe Simeon is asking if it is present in other browser engines. Since those are all on chromium, it would be expected for them to be behaving the same more or less. |
Ah, ok, understood. Sorry but I can't help you there. My extension is
currently limited to Chromium based browsers, so I don't have a test
environment for anything else.
…On Fri, Dec 6, 2024 at 11:21 AM patrick kettner ***@***.***> wrote:
I believe Simeon is asking if it is present in other browser engines.
Since those are all on chromium, it would be expected for them to be
behaving the same more or less.
If the behavior is consistent between browsers, then it would likely need
to come from an upstream spec change. Extensions largely inherit what
counts as user activation from the engine. So it would probably need to go
up to the UAPM section
<https://html.spec.whatwg.org/multipage/interaction.html#user-activation-processing-model>
of WHATWG for a decision on wether or not this is expected behavior.
—
Reply to this email directly, view it on GitHub
<#736 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJGK6JIXHD2YVQG6BGSW3L2EHFKJAVCNFSM6AAAAABTDO5RF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRTGY3DGOJUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@dotproto would you be able to check if it works in firefox? I know browser.identity.launchWebAuthFlow requires user interaction to launch, fwiw |
The same behavior in the web platform as can be seen by copypasting this URL in the address bar |
if (confirm('BrainTool is not currently open. Click OK to open it now.')) { chrome.sidePanel.open({}); }
throws:
"Error:
sidePanel.open()
may only be called in response to a user gesture."I'm guessing there might be an issue with the system dialogs running in a different context, but confirm() seems like one of the simplest and most obviously user-intended gestures.
The text was updated successfully, but these errors were encountered: