Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish minutes of 2021-10-28 meeting #124

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Publish minutes of 2021-10-28 meeting #124

merged 1 commit into from
Nov 4, 2021

Conversation

dotproto
Copy link
Member

@dotproto dotproto commented Oct 29, 2021 •
edited by Rob--W
Loading

@dotproto dotproto requested review from Rob--W, xeenon and zombie October 29, 2021 20:41
zombie
zombie approved these changes Oct 30, 2021
View reviewed changes
_minutes/2021-10-28-wecg.md Outdated Show resolved Hide resolved
_minutes/2021-10-28-wecg.md Outdated Show resolved Hide resolved
Rob--W
Rob--W reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you accept the suggestions from me and Tomislav, squash all changes (and update the commit to consist of just "Publish minutes of 2021-10-28") and force-push the change?

The notes here should be kept in sync with the source at https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit#heading=h.7m7i1y6b2ibm, as their content should be equivalent.

Together with updating the meeting notes, I typically update the entry in _minutes/README.md.

But I noticed that there are multiple issues in the schedule, so I'll file a follow-up PR for that.

_minutes/2021-10-28-wecg.md Outdated Show resolved Hide resolved
_minutes/2021-10-28-wecg.md Outdated Show resolved Hide resolved
@dotproto
Copy link
Member Author

dotproto commented Nov 1, 2021

@Rob--W Made the requested changes. I also changed PDT to PST for the next meeting and updated _minutes/README.md.

I'm tentatively adding 11/25 as a future meeting, but that's close enough to Thanksgiving in the US so some folks may have conflicts. I've just opened #130 to discuss.

@dotproto dotproto requested a review from Rob--W November 1, 2021 17:37
Rob--W
Rob--W reviewed Nov 1, 2021
View reviewed changes
_minutes/README.md Outdated
@@ -1,21 +1,20 @@
# Meetings

The [WebExtensions Community group](https://www.w3.org/community/webextensions/) meets virtually every other week, for one hour.
The instructions to join the meeting and agenda are available at https://www.w3.org/events/meetings/7fc25ca5-a50c-498c-82e5-f48fc96e1637.
The [WebExtensions Community group](https://www.w3.org/community/webextensions/) meets virtually every other week, for one hour. The instructions to join the meeting and agenda are available at https://www.w3.org/events/meetings/7fc25ca5-a50c-498c-82e5-f48fc96e1637.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you merge them on one line?

If you want to change this line anyway, let's change the link to the one from https://github.com/w3c/webextensions/pull/129/files (and then I can close that PR)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a trivial change I'll force-push the whitespace change to the branch and then merge the PR

@Rob--W Rob--W force-pushed the meeting-2021-10-28 branch from 0ecdd29 to c59c139 Compare November 4, 2021 12:10
@Rob--W Rob--W merged commit 50d2e7a into main Nov 4, 2021
github-actions bot added a commit that referenced this pull request Nov 4, 2021
@Rob--W @github-actions
Merge pull request #124 from w3c/meeting-2021-10-28
81cf562 
SHA: 50d2e7a
Reason: push, by @Rob--W

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Rob--W Rob--W mentioned this pull request Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W left review comments

@zombie zombie zombie approved these changes

@xeenon xeenon Awaiting requested review from xeenon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotproto @zombie @Rob--W