Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heading levels in specification. #572

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Fix heading levels in specification. #572

merged 1 commit into from
Mar 22, 2024

Conversation

oliverdunk
Copy link
Member

@oliverdunk oliverdunk commented Mar 22, 2024

We were using ## as the top level heading but this does not match the expectation of bikeshed.

Before After
Screenshot 2024-03-22 at 14 32 12 Screenshot 2024-03-22 at 14 31 46

Preview | Diff

We were using ## as the top level heading but this does not match
the expectation of bikeshed.
@oliverdunk oliverdunk requested a review from dotproto March 22, 2024 21:32
Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotproto dotproto merged commit 43ff042 into main Mar 22, 2024
3 checks passed
@dotproto dotproto deleted the fix-heading-levels branch March 22, 2024 21:38
github-actions bot added a commit that referenced this pull request Mar 22, 2024
SHA: 43ff042
Reason: push, by dotproto

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Mar 22, 2024
SHA: 43ff042
Reason: push, by dotproto

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants