-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a plural array type like "permissions"
for simplicity
#614
Use a plural array type like "permissions"
for simplicity
#614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SHA: 1aa7f75 Reason: push, by mukul-p Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 1aa7f75 Reason: push, by mukul-p Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There is one "color-schemes" instead of "color_schemes" in the commit. Basically with this PR the ability to set the color scheme to a single string value is dropped? |
This PR was created a week before the previous Tuesday more as a question than a directive. I like the idea of
Maybe you have other ideas beyond those. Perhaps you could share your ideas here or better yet create a PR with your preference and rationale. |
Thinking out loud the most common use case seems to be either set Requiring an array would mean the syntax is more verbose with the benefit of having a single syntax for any situation and indicate other color_schemes can be added here. In any case, I feel we either go with this PR, always use Would love to hear about other contributors who helped decide on this before @hanguokai @xeenon |
No description provided.