Skip to content

feat(productions/type): support ObservableArray #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2020
Merged

feat(productions/type): support ObservableArray #481

merged 2 commits into from
Jun 29, 2020

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Jun 28, 2020 •
edited
Loading

Corresponds to whatwg/webidl#840.

This patch closes #__ and includes:

  • A relevant test
  • A relevant documentation update

@saschanaz saschanaz requested a review from marcoscaceres June 28, 2020 23:34
marcoscaceres
marcoscaceres approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saschanaz saschanaz merged commit d11cc22 into gh-pages Jun 29, 2020
@saschanaz saschanaz deleted the observablearray branch June 29, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @marcoscaceres