feat: allow adding additional members to production parse methods #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
This is also due to microsoft/TypeScript#4628 which prevents changing the signature of static methods on inherited classes.
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
saschanaz
requested changes
Jun 20, 2023
| @@ -16,8 +20,9 @@ export class CallbackInterface extends Container { | |||
| tokeniser, | |||
| new CallbackInterface({ source: tokeniser.source, tokens }), | |||
| { | |||
| inheritable: !partial, | |||
| inheritable: !!inheritable, | |||
There was a problem hiding this comment.
Can we make this change separately? We should either change all partial to inheritable everywhere or keep it everywhere, and making that change here sounds like out-of scope.
There was a problem hiding this comment.
Wasn't the issue here that callback interface doesn't support partial at all?
There was a problem hiding this comment.
Oh hmm, I think we talked about it somewhere but can't find it anywhere, do you remember? I now wonder why we need it at all, neither the spec nor the mozilla-central uses inheritance for callback interfaces, right?
There was a problem hiding this comment.
Ah I found it, and I think we should just remove inheritables here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the extMembers key to the production parse method's option bag. The extMembers key is used to add additional members that may exist during parsing. This is especially useful for allowing custom productions expand existing productions.
Additionally, this PR adds extensions to the parse method so that users can add additional allowedMembers on a per production basis.