-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¦ Release @webref/css@6.16.1 #1358
Conversation
76c131e
to
9b3d1af
Compare
e7f6d54
to
bfd0344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full diff looks correct. Most changes are due to a rename from "element" to "box" in css-anchor-positioning. The move to "dangling values" in css-sizing-4 would ideally not happen but cannot be prevented for the time being, see w3c/reffy#1647
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of removed values and new dangling values in css-sizing-4 https://github.com/w3c/webref/actions/runs/11287627831/job/31393872808#step:10:592
The suppressions probably impact consuming tools. Let's see if we manage to prioritize fixing the issue within the next few days in Reffy. If not, we'll merge as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
8a1490b
to
0606fb4
Compare
0606fb4
to
666af30
Compare
Looking into it again, the move to "dangling values" in css-sizing-4 has nothing to do with w3c/reffy#1647, and the move is actually correct. Or at least correct in the sense that the code is not smart enough to figure out that these values should simply not be listed at all. The changes were triggered by w3c/csswg-drafts#10987, which fixed two year old bug: if the new values are defined for That fix is correct, and triggered the removal from the main part of the extract (note the values continue to be defined for the base properties The extraction logic in Reffy tries to only list constructs to which a value applies directly. The logic acknowledges that CSS specs often lists additional constructs, and tries to work around that as best as it can. Unfortunately, the extraction logic only knows about properties defined in the spec being crawled, and thus cannot tell that Ideally, we would add a post-processing module that takes all CSS extracts into account and drops such dangling values. I'll create an issue in Reffy to track this. In the meantime, that PR is good to go! |
β NEVER add commits to this pull request.
π€ This pull request was automatically created to facilitate human review of
@webref/css
changes triggered by curated data at 435f0a5.π§ Please review the diff below and version numbers. If all looks good, merge this pull request to release the changes to npm.
π¦ Latest released
@webref/css
package was v6.16.0. Merging this pull request will release v6.16.1. Make sure that the bump is the right one for the changes.β If any change needs to be made before release, do not add a commit to this pull request. Changes should rather be handled in a separate pull request and pushed to the main branch. You may leave this pull request open in the meantime, or close it. The pre-release job will automatically update this pull request or create a new one once the updates have made their way to the main branch.
π The actual change introduced by this pull request is a version bump in
packages/css/package.json
. You do not need to review that change. The bumped version is not the version that will be released when this pull request is merged, but rather the version that will be released next time.