Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-drop incorrect wrapping quotes in values #1448

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Auto-drop incorrect wrapping quotes in values #1448

merged 1 commit into from
Jan 23, 2025

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Jan 23, 2025

Pending resolution of speced/bikeshed#3011 or updates made to underlying specs, this adds a temporary mechanism to drop offending wrapping single quotes in the definitions of properties and values during data curation, so that we may publish a new version of @webref/css while the problem gets fixed.

Pending resolution of speced/bikeshed#3011 or updates
made to underlying specs, this adds a temporary mechanism to drop offending
wrapping single quotes in the definitions of properties and values during data
curation, so that we may publish a new version of `@webref/css` while the
problem gets fixed.
@tidoust tidoust requested a review from dontcallmedom January 23, 2025 14:22
Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting that this stretches the semantics implied by the file name :)

(relatedly, to confirm my understanding - if this wasn't a temporary thing with the associated pain of sync'd releases, it would more logically fit as a reffy post-processing item, right?)

@tidoust
Copy link
Member Author

tidoust commented Jan 23, 2025

noting that this stretches the semantics implied by the file name :)

Surely, file names are meant to be opaque ;)

(relatedly, to confirm my understanding - if this wasn't a temporary thing with the associated pain of sync'd releases, it would more logically fit as a reffy post-processing item, right?)

Boundaries are probably not as crisp as I'd like them to be, but the nuance I keep in mind between post-processing in Reffy and data curation in Webref is that the former may complete the data but it does not "patch" or curate it. As such, I would probably argue that this patching logic needs to stay in Webref (renaming the script to be more generically about curating css properties and values). Of course, dfns patching is already an exception to the rule, but that's due to the fact that we don't actually curate dfns extracts in Webref for now, whereas we do curate CSS/IDL extracts.

@tidoust tidoust merged commit 34af0e4 into main Jan 23, 2025
1 check passed
@tidoust tidoust deleted the patch-quotes branch January 23, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants