Use Infinity as highWaterMark value instead of having the sizeAlgorithm returning zero #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hm returning zero. This makes it clearer backpressure is disabled. Mention reducing buffering as the reason behind this choice. Fixes w3c#188.
jan-ivar
reviewed
Jul 27, 2023
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
jan-ivar
reviewed
Jul 27, 2023
jan-ivar
reviewed
Jul 27, 2023
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
jan-ivar
approved these changes
Jul 27, 2023
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 27, 2023
SHA: c18f6ae Reason: push, by jan-ivar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer backpressure is disabled.
Mention reducing buffering as the reason behind this choice.
Fixes #188.
Preview | Diff