Fix setConfiguration default value handling to match implementations. #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For review I recommend split view with whitespace hidden. |
alvestrand
approved these changes
Nov 11, 2021
jan-ivar
force-pushed
the
configdefaults
branch
from
1cf7f4d to
e018db5
Compare
dontcallmedom
added a commit
that referenced
this pull request
Jan 28, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
May 5, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
Jul 19, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
Aug 19, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
Sep 27, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 15, 2023
* Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint
23 tasks
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…only Automatic update from web-platform-tests Add tests for w3c/webrtc-pc#2691 (#43166) * Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint -- wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf wpt-pr: 43166
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…only Automatic update from web-platform-tests Add tests for w3c/webrtc-pc#2691 (#43166) * Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint -- wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf wpt-pr: 43166
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…only Automatic update from web-platform-tests Add tests for w3c/webrtc-pc#2691 (#43166) * Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint -- wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf wpt-pr: 43166
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…only Automatic update from web-platform-tests Add tests for w3c/webrtc-pc#2691 (#43166) * Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint -- wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf wpt-pr: 43166
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2023
…only Automatic update from web-platform-tests Add tests for w3c/webrtc-pc#2691 (#43166) * Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint -- wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf wpt-pr: 43166 UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2023
…only Automatic update from web-platform-tests Add tests for w3c/webrtc-pc#2691 (#43166) * Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint -- wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf wpt-pr: 43166 UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2023
…only Automatic update from web-platform-tests Add tests for w3c/webrtc-pc#2691 (#43166) * Add tests for w3c/webrtc-pc#2691 https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy This adds the relevant test for rtcpMuxPolicy * Fix lint -- wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf wpt-pr: 43166 UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2690.
Preview | Diff