Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize MTI stats with webrtc-stats cleanup #2744

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Synchronize MTI stats with webrtc-stats cleanup #2744

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8469085
Remove "sender" and "receiver" from MTI stats
dontcallmedom Jun 16, 2022
702efa9
Associate packetsDiscarded with updated dictionary hierarchy
dontcallmedom Jun 16, 2022
d3f3bc0
Remove RTCDoecStats.codecType from MTI
dontcallmedom Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15397,7 +15397,7 @@ <h3>
</td>
<td data-tests=
"RTCPeerConnection-getStats.https.html,RTCPeerConnection-mandatory-getStats.https.html">
{{RTCCodecStats/payloadType}}, {{RTCCodecStats/codecType}},
{{RTCCodecStats/payloadType}},
{{RTCCodecStats/mimeType}}, {{RTCCodecStats/clockRate}},
{{RTCCodecStats/channels}}, {{RTCCodecStats/sdpFmtpLine}}
</td>
Expand Down Expand Up @@ -15425,7 +15425,6 @@ <h3>
{{RTCReceivedRtpStreamStats/packetsReceived}},
{{RTCReceivedRtpStreamStats/packetsLost}},
{{RTCReceivedRtpStreamStats/jitter}},
{{RTCReceivedRtpStreamStats/packetsDiscarded}},
{{RTCReceivedRtpStreamStats/framesDropped}}
</td>
</tr>
Expand All @@ -15435,14 +15434,14 @@ <h3>
</td>
<td data-tests=
"RTCPeerConnection-getStats.https.html,RTCPeerConnection-track-stats.https.html,RTCRtpReceiver-getStats.https.html,RTCPeerConnection-mandatory-getStats.https.html">
{{RTCInboundRtpStreamStats/receiverId}},
{{RTCInboundRtpStreamStats/remoteId}},
{{RTCInboundRtpStreamStats/framesDecoded}},
{{RTCInboundRtpStreamStats/nackCount}},
{{RTCInboundRtpStreamStats/framesReceived}},
{{RTCInboundRtpStreamStats/bytesReceived}},
{{RTCInboundRtpStreamStats/totalAudioEnergy}},
{{RTCInboundRtpStreamStats/totalSamplesDuration}}
{{RTCInboundRtpStreamStats/packetsDiscarded}},
</td>
</tr>
<tr>
Expand Down Expand Up @@ -15475,7 +15474,6 @@ <h3>
</td>
<td data-tests=
"RTCPeerConnection-getStats.https.html,RTCPeerConnection-track-stats.https.html,RTCRtpSender-getStats.https.html,RTCPeerConnection-mandatory-getStats.https.html">
{{RTCOutboundRtpStreamStats/senderId}},
{{RTCOutboundRtpStreamStats/remoteId}},
{{RTCOutboundRtpStreamStats/framesEncoded}},
{{RTCOutboundRtpStreamStats/nackCount}},
Expand Down Expand Up @@ -15505,7 +15503,6 @@ <h3>
{{RTCReceivedRtpStreamStats/packetsReceived}},
{{RTCReceivedRtpStreamStats/packetsLost}},
{{RTCReceivedRtpStreamStats/jitter}},
{{RTCReceivedRtpStreamStats/packetsDiscarded}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packetsDiscarded seems well implemented.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also still in the stats spec AFAICT

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the patch moves it to its new parent RTCInboundRtpStreamStats

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's implemented in inbound-rtp, not remote-inbound-rtp. The WPT tests both, one passes on all browsers and one fails on all browsers.

The PR moved it from RTCReceivedRtpStreamStats which implied both inbound-rtp and remote-inbound-rtp to only RTCInboundRtpStreamStats. This matches the implementation status

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining! LGTM then

{{RTCReceivedRtpStreamStats/framesDropped}}
</td>
</tr>
Expand Down Expand Up @@ -15620,23 +15617,6 @@ <h3>
{{RTCDataChannelStats/bytesReceived}}
</td>
</tr>
<tr>
<th class="row">
{{RTCStatsType/"sender"}}
</th>
<td rowspan="2">
{{RTCMediaHandlerStats}}
</td>
<td rowspan="2" data-tests=
"RTCPeerConnection-track-stats.https.html,RTCPeerConnection-mandatory-getStats.https.html">
{{RTCMediaHandlerStats/trackIdentifier}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we should make it mandatory to implement RTCInboundRtpStreamStats.trackIdentifier. It got moved there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide it as a separate PR since that one got merged now? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do #2747

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #2748

</td>
</tr>
<tr>
<th class="row">
{{RTCStatsType/"receiver"}}
</th>
</tr>
<tr>
<th class="row">
{{RTCStatsType/"transport"}}
Expand Down