-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to RTCIceCredentialType #2767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aboba Should I move it to the extensions repository, or should we just remove all the OAuth bits from it to have it completely gone? |
jan-ivar
approved these changes
Sep 8, 2022
youennf
approved these changes
Sep 8, 2022
sideshowbarker
added a commit
to mdn/browser-compat-data
that referenced
this pull request
Sep 10, 2022
w3c/webrtc-pc@0cba163 (w3c/webrtc-pc#2767) removed RTCIceServer»credentialType and RTCIceCredentialType from the WebRTC spec.
sideshowbarker
added a commit
to mdn/content
that referenced
this pull request
Sep 10, 2022
w3c/webrtc-pc@0cba163 (w3c/webrtc-pc#2767) removed RTCIceServer»credentialType and RTCIceCredentialType from the WebRTC spec. Related BCD change: mdn/browser-compat-data#17748
sideshowbarker
added a commit
to mdn/browser-compat-data
that referenced
this pull request
Sep 10, 2022
w3c/webrtc-pc@0cba163 (w3c/webrtc-pc#2767) removed RTCIceServer»credentialType and RTCIceCredentialType from the WebRTC spec. Related MDN change: mdn/content#20505
sideshowbarker
added a commit
to mdn/browser-compat-data
that referenced
this pull request
Sep 10, 2022
w3c/webrtc-pc@0cba163 (w3c/webrtc-pc#2767) removed RTCIceServer»credentialType and RTCIceCredentialType from the WebRTC spec. Related MDN change: mdn/content#20505
teoli2003
pushed a commit
to mdn/content
that referenced
this pull request
Sep 10, 2022
w3c/webrtc-pc@0cba163 (w3c/webrtc-pc#2767) removed RTCIceServer»credentialType and RTCIceCredentialType from the WebRTC spec. Related BCD change: mdn/browser-compat-data#17748
queengooborg
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Sep 11, 2022
* Deprecate RTCIceServer»credentialType & RTCIceCredentialType w3c/webrtc-pc@0cba163 (w3c/webrtc-pc#2767) removed RTCIceServer»credentialType and RTCIceCredentialType from the WebRTC spec. Related MDN change: mdn/content#20505 * Drop RTCIceCredentialType»oauth > ✖ api.RTCIceCredentialType.oauth - Error → feature was never > implemented in any browser and the specification has been abandoned
dontcallmedom
added a commit
that referenced
this pull request
Sep 27, 2022
himanshugarg
pushed a commit
to himanshugarg/content
that referenced
this pull request
Sep 27, 2022
w3c/webrtc-pc@0cba163 (w3c/webrtc-pc#2767) removed RTCIceServer»credentialType and RTCIceCredentialType from the WebRTC spec. Related BCD change: mdn/browser-compat-data#17748
23 tasks
Ahmad-S792
added a commit
to Ahmad-S792/WebKit
that referenced
this pull request
Jul 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=276595 Reviewed by NOBODY (OOPS!). This patch syncs `RTCIceServer` as per web specification [1]: [1] https://w3c.github.io/webrtc-pc/#dom-rtciceserver It removes `RTCIceCredentialType` as per [2]: [2] w3c/webrtc-pc#2767 * Source/WebCore/Modules/mediastream/RTCIceServer.h: * Source/WebCore/Modules/mediastream/RTCIceServer.idl:
Ahmad-S792
added a commit
to Ahmad-S792/WebKit
that referenced
this pull request
Jul 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=276595 Reviewed by NOBODY (OOPS!). This patch syncs `RTCIceServer` as per web specification [1]: [1] https://w3c.github.io/webrtc-pc/#dom-rtciceserver It removes `RTCIceCredentialType` as per [2]: [2] w3c/webrtc-pc#2767 * Source/WebCore/Modules/mediastream/RTCIceServer.h: * Source/WebCore/Modules/mediastream/RTCIceServer.idl: * LayoutTests/imported/w3c/web-platform-tests/webrtc-extensions/RTCOAuthCredential-expected.txt: Rebaselined
webkit-commit-queue
pushed a commit
to Ahmad-S792/WebKit
that referenced
this pull request
Jul 16, 2024
https://bugs.webkit.org/show_bug.cgi?id=276595 Reviewed by Youenn Fablet. This patch syncs `RTCIceServer` as per web specification [1]: [1] https://w3c.github.io/webrtc-pc/#dom-rtciceserver It removes `RTCIceCredentialType` as per [2]: [2] w3c/webrtc-pc#2767 * Source/WebCore/Modules/mediastream/RTCIceServer.h: * Source/WebCore/Modules/mediastream/RTCIceServer.idl: * LayoutTests/imported/w3c/web-platform-tests/webrtc-extensions/RTCOAuthCredential-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/281007@main
a-wing
added a commit
to a-wing/webrtc-http-ingest-protocol
that referenced
this pull request
Nov 20, 2024
credential-type(marked deprecated) webrtc-rs/webrtc#584 w3c/webrtc-pc@0cba163 w3c/webrtc-pc#2767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2746
Preview | Diff