Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maxFramerate like scaleResolutionDownBy for audio. #2799

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Remove maxFramerate like scaleResolutionDownBy for audio. #2799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6df32ed
Remove maxFramerate like scaleResolutionDownBy for audio.
jan-ivar Nov 16, 2022
dd72ce4
Hit setParameters as well as addTransceiver.
jan-ivar Nov 16, 2022
240b65f
Add amendments
jan-ivar Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,13 @@
"type": "correction",
"status": "candidate",
"id": 20
},
{
"description": "Remove maxFramerate like scaleResolutionDownBy for audio",
"pr": 2799,
"type": "correction",
"status": "candidate",
"id": 24
}
],
"setparameters-algo": [
Expand All @@ -293,6 +300,13 @@
"type": "addition",
"status": "candidate",
"id": 19
},
{
"description": "Remove maxFramerate like scaleResolutionDownBy for audio",
"pr": 2799,
"type": "correction",
"status": "candidate",
"id": 24
}
],
"create-sender-algo": [
Expand Down
18 changes: 12 additions & 6 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8140,8 +8140,10 @@ <h2>
<li data-tests="RTCRtpParameters-encodings.html">
<p>
If <var>kind</var> is `"audio"`, remove the
{{RTCRtpEncodingParameters/scaleResolutionDownBy}}
member from all encodings that [=map/contain=] one.
{{RTCRtpEncodingParameters/scaleResolutionDownBy}} and
{{RTCRtpEncodingParameters/maxFramerate}}
members from all encodings that [=map/contain=] any of
them.
</p>
</li>
<li data-tests="RTCRtpParameters-encodings.html">
Expand Down Expand Up @@ -8905,9 +8907,10 @@ <h2>
<li data-tests="RTCRtpParameters-encodings.html">
<p>
If <a>transceiver kind</a> is `"audio"`, remove the
{{RTCRtpEncodingParameters/scaleResolutionDownBy}}
member from all <var>encodings</var> that
[=map/contain=] one.
{{RTCRtpEncodingParameters/scaleResolutionDownBy}} and
{{RTCRtpEncodingParameters/maxFramerate}}
members from all <var>encodings</var> that
[=map/contain=] any of them.
</p>
</li>
<li data-tests="RTCRtpParameters-encodings.html">
Expand Down Expand Up @@ -9622,7 +9625,10 @@ <h2>
"idlMemberType">double</span>
</dt>
<dd>
<p>When present, indicates the maximum frame rate that can be used to
<p>
This member can only be present if the sender's <code class=
"gum">kind</code> is <code>"video"</code>.
When present, indicates the maximum frame rate that can be used to
send this encoding, in frames per second. The <a>user agent</a> is free
to allocate bandwidth between the encodings, as long as the
{{maxFramerate}} value is not exceeded.</p>
Expand Down