-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove setCodecPreferences note already covered by JSEP #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2024
asserting what was said in the note that was removed as redundant with JSEP: w3c/webrtc-pc#2941 BUG=None Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2024
asserting what was said in the note that was removed as redundant with JSEP: w3c/webrtc-pc#2941 BUG=None Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263260}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2024
asserting what was said in the note that was removed as redundant with JSEP: w3c/webrtc-pc#2941 BUG=None Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263260}
alvestrand
approved these changes
Feb 22, 2024
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2024
asserting what was said in the note that was removed as redundant with JSEP: w3c/webrtc-pc#2941 BUG=None Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263260}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 28, 2024
…e, a=testonly Automatic update from web-platform-tests webrtc wpt: add test for removed sCP note asserting what was said in the note that was removed as redundant with JSEP: w3c/webrtc-pc#2941 BUG=None Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263260} -- wpt-commits: 89d651c02dd9c3a01cd6e05e011d1c362f2122c1 wpt-pr: 44698
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Feb 28, 2024
…e, a=testonly Automatic update from web-platform-tests webrtc wpt: add test for removed sCP note asserting what was said in the note that was removed as redundant with JSEP: w3c/webrtc-pc#2941 BUG=None Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263260} -- wpt-commits: 89d651c02dd9c3a01cd6e05e011d1c362f2122c1 wpt-pr: 44698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2933
I'd classify this as editorial
Preview | Diff