Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block ports on fetch's bad ports list & use WebTransportError for it and CSP. #378

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Block ports on fetch's bad ports list & use WebTransportError for it and CSP. #378

merged 3 commits into from
Dec 8, 2021

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Dec 6, 2021 •
edited by pr-preview bot
Loading

Fixes #229.

Preview | Diff

@jan-ivar jan-ivar requested a review from yutakahirano December 6, 2021 20:11
@jan-ivar jan-ivar self-assigned this Dec 6, 2021
@jan-ivar
Copy link
Member Author

jan-ivar commented Dec 6, 2021

cc @annevk

@yutakahirano
Copy link
Contributor

Should we use SecurityError here?

@annevk
Copy link
Member

annevk commented Dec 7, 2021

Why does CSP not use WebTransportError? I think ideally this uses the same signal as obtaining a connection returning failure. In the future we might want to move the port check there. And potentially we could move some of the CSP checking there as well, at least in theory.

@jan-ivar jan-ivar changed the title Block ports on fetch's bad ports list. Block ports on fetch's bad ports list & use WebTransportError for it and CSP. Dec 7, 2021
@jan-ivar jan-ivar merged commit 26e22fe into w3c:main Dec 8, 2021
@jan-ivar jan-ivar deleted the prohibited branch December 8, 2021 00:20
github-actions bot added a commit that referenced this pull request Dec 8, 2021
@jan-ivar @github-actions
Merge pull request #378 from jan-ivar/prohibited
0e67d4a 
SHA: 26e22fe
Reason: push, by @jan-ivar

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yutakahirano
Copy link
Contributor

@jan-ivar, can you update the test as well?

@jan-ivar jan-ivar mentioned this pull request Dec 9, 2021
Merged
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 20, 2021
@yutakahirano
Throw WebTransportError when seeing CSP error
a38315e 
Implementing (part of) w3c/webtransport#378.
This is subtle enough to skip the intent process.

This fixes one test failure, but the test is skipped at TestExpectations
so there is no changes under web_tests/.

Bug: None
Change-Id: I754e79ef1590ac09c6328d1950e0109eab9e2223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3350153
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952858}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@yutakahirano @copybara-github
Throw WebTransportError when seeing CSP error
8365de2 
Implementing (part of) w3c/webtransport#378.
This is subtle enough to skip the intent process.

This fixes one test failure, but the test is skipped at TestExpectations
so there is no changes under web_tests/.

Bug: None
Change-Id: I754e79ef1590ac09c6328d1950e0109eab9e2223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3350153
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952858}
NOKEYCHECK=True
GitOrigin-RevId: a38315e18fbb4f23cee3c07e7fd0d467f76990a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@jan-ivar jan-ivar

Labels
Needs test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port blocking
3 participants
@jan-ivar @yutakahirano @annevk