Reject getStats() promise when the connection is closed/failed. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
reviewed
Oct 24, 2023
index.bs
Outdated
Comment on lines
990
to
991
| 1. If |transport|.{{[[State]]}} is `"closed"` or `"failed"`, | ||
| [=reject=] |p| with an {{InvalidStateError}} and abort these steps. |
There was a problem hiding this comment.
I think we should do the same state check in the synchronous steps (since the timing of promise state is synchronously observable in a JS debugger).
|
Meeting:
|
jan-ivar
approved these changes
Nov 21, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 21, 2023
SHA: 2c82082 Reason: push, by jan-ivar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 22, 2024
w3c/webtransport#558 requires providing stats after connection has been closed; this ensures we always have some valid stats as soon as the connection is open, and also that we have the most recent stats at the moment the connection is closed. Change-Id: Ic94ea86a6b2bb5f84a26fa8c1f3196549bb20368 Bug: 1519563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5197933 Reviewed-by: David Bertoni <dbertoni@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1250521}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #557
Preview | Diff