Rename "Data Recvd" to "all data committed" #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in ietf-wg-webtrans/draft-ietf-webtrans-http2#101 This is NOT the only place where this state is used. That one needs a few more grey matter cycles before I have a resolution. I'll open an issue instead.
ekinnear
approved these changes
Jan 23, 2024
|
I believe this will mean that the API will be unable to reset streams that the sender has already sent a FIN on, which is why that step has been added in the first place. |
|
Meeting:
|
|
Meeting:
|
|
Just double checking, do we need to modify this to mention "all data committed" instead of "enter the Data Recvd state", based on ietf-wg-webtrans/draft-ietf-webtrans-overview#14? |
jan-ivar
changed the title
github-actions bot
added a commit
that referenced
this pull request
Jan 14, 2025
SHA: ec3ee72 Reason: push, by jan-ivar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in ietf-wg-webtrans/draft-ietf-webtrans-http2#103
This is NOT the only place where this state is used. That one needs a few more grey matter cycles before I have a resolution. I'll open an issue instead.
Preview | Diff