Add support for client initiated drain #606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
approved these changes
Jul 2, 2024
jan-ivar
reviewed
Jul 2, 2024
| 1. If |transport|.{{[[State]]}} is `"closed"` or `"failed"`, [=throw=] an {{InvalidStateError}} | ||
| and abort these steps. | ||
| 1. Set |transport|.{{[[State]]}} to `"draining"`. | ||
| 1. Let |draining| be |transport|.{{[[Draining]]}}. |
There was a problem hiding this comment.
The existing definitions of [[Draining]] and concept of draining are now incomplete as they specifically only mention that they describe server-initiated drain. These need to be updated to include that this state can be initiated client-side.
|
Meeting:
|
|
Meeting:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436.
I'm not totally sure what "draining" is doing here, if we're not blocking new stream creations or cleaning up the transport object, but I think this is what was discussed on the issue.
Preview | Diff