Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about empty string in screen labels. #102

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Add note about empty string in screen labels. #102

merged 7 commits into from
Jun 7, 2022

Conversation

bradtriebwasser
Copy link
Contributor

@bradtriebwasser bradtriebwasser commented Jun 3, 2022

Early API adopters / partners have a preference for an empty label when the platform cannot determine an accurate label (e.g. EDID data is empty) rather than the user agent providing a string (i.e. "Unknown Display"). I think the spec should be clear that an empty string is valid (and the reasoning). I added a note about the user agent possibly returning an empty string when the display label is not available.


Preview | Diff

@bradtriebwasser
Copy link
Contributor Author

I have linked my w3c account now. Is there a way to re-run the failed check?

@w3cbot
Copy link

w3cbot commented Jun 3, 2022

anssiko marked as non substantive for IPR from ash-nazg.

@anssiko
Copy link
Member

anssiko commented Jun 3, 2022

@bradtriebwasser it takes a while for that change to propagate, so I unblocked this for you.

@anssiko
Copy link
Member

anssiko commented Jun 3, 2022

A new push to this branch should re-run the IPR check. You’re a WG participant so no worries even if the check fails.

Copy link
Member

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refining this note! I have some thoughts.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@bradtriebwasser bradtriebwasser merged commit 8df8fb5 into w3c:main Jun 7, 2022
github-actions bot added a commit that referenced this pull request Jun 7, 2022
SHA: 8df8fb5
Reason: push, by @bradtriebwasser

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bradtriebwasser added a commit to bradtriebwasser/window-placement that referenced this pull request Oct 19, 2022
* Add note about empty string in screen labels.

* Add E-EDID reference and re-word empty string.

* Make wording less specific about VESA attributes used.

* Remove anchor hash from link.

* Remove space.

* Remove double "if".

* singularize user agents.
bradtriebwasser added a commit to bradtriebwasser/window-placement that referenced this pull request Oct 19, 2022
* Add note about empty string in screen labels.

* Add E-EDID reference and re-word empty string.

* Make wording less specific about VESA attributes used.

* Remove anchor hash from link.

* Remove space.

* Remove double "if".

* singularize user agents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants