-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listing with pagination #153
Conversation
Is there a good summary somewhere of why the earlier version of pagination was removed? |
I assume you are referring to #124 which was replaced by #145. There were a few issues discussed in the discovery calls and in linked issues. I will summarize what I remember:
|
Thanks for summarizing @farshidtz !
Sorry for potentially discussing the same stuff again and again, but maybe I've just missed some basic assumptions like "responses should be JSON-LD in case ... because they help / allow for ...". |
Sorry that was a wrong statement (at least the sparql part). But for JSONPath and XPath, the result of executing the expressions to do filtering on the collection will be an array. There could be other formats on function calls for e.g. to count elements. We need to go back to the Search API spec and check if we have claimed something wrong. But that is not relevant to this PR.
It is (to my limited understanding of linked data), a bad practice to embed JSON-LD (i.e. an RDF document) in plain JSON. @AndreaCimminoArriaga has discussed this in the calls few times.
That is not part of this PR. Anyway, those are recommendations based on HTTP specification to allow incremental transfer of possibly large TDs in IoT and other environments. We had a lengthy discussion in #145. The same recommendation should be added for retrieval or submission of one TD (#117). The servers are NOT mandated to follow it. The data model, serialization format, and transfer encoding are different topics. The protocol-specific statements for HTTP/1.1 and HTTP/2 are to do efficient transfer on the named protocols.
I think the reason is same as why the TD should be JSON-LD. |
Thanks & apologies again for (too much) insisting. That was my missing part. Anyway, would be great to have streamlined search APIs and even better to have both search and listing APIs streamlined. |
@egekorkan - I know that you are working on System Descriptions. Have you ever come across the issue of embedding TDs having their own context inside a JSON-LD frame having another context or just a plain JSON? If yes, how did you solve that? Thanks! |
@wiresio so in SDs there are TD fragments that are of interest for a system and they identified in the SD ontology with the TD context: https://github.com/tum-esi/wot-system-description/blob/b45b06f97da8aca507a047865b1148d2fb3357a6/paper-mentions/3_Context/sdContext.json#L22 However, I think that I do not answer your question exactly :/ |
@egekorkan - Thanks for pointing me to your work! Looks like it is not directly applicable for TDD purposes ... was just a thought that came into my mind. |
This will add pagination to the spec. It includes the minimum requirements taken from #130.
This is compatible with the existing listing mechanism.
Note: This depends on #152 and should not be merged beforehand.
Todos:
Other related issues/PRs: #16, #145, #149
Preview | Diff