Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate assertions in registration API #267

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Jan 29, 2022

Closes #266


Preview | Diff

@farshidtz farshidtz requested a review from egekorkan January 29, 2022 11:19
Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@farshidtz farshidtz force-pushed the assertions-disambiguation branch from 8b79208 to ea924db Compare January 31, 2022 15:16
@mmccool mmccool merged commit 5d1fb65 into w3c:main Jan 31, 2022
@benfrancis
Copy link
Member

"The Registration API MUST provide interfaces to create, retrieve, update, delete, and list (CRUDL) TDs."

@farshidtz Does this mean that read-only (#208) directories are not allowed?

@farshidtz farshidtz deleted the assertions-disambiguation branch January 31, 2022 16:09
@farshidtz
Copy link
Member Author

"The Registration API MUST provide interfaces to create, retrieve, update, delete, and list (CRUDL) TDs."

@farshidtz Does this mean that read-only (#208) directories are not allowed?

The assertion is not new. The Registration API must provide all of CURDL.

The Registration API is mandatory for a ThingDirectory.

My personal thoughts: a read-only directory can choose not to implement the Registration API and instead a variant of it which only implements retrieval and listing. A read-only directory class can, in future, define that.

@benfrancis benfrancis mentioned this pull request Jan 31, 2022
@benfrancis
Copy link
Member

benfrancis commented Jan 31, 2022

@farshidtz OK, if in WoT Discovery 1.0 all directories have to be writable, then that's going to be a problem for WebThings Gateway (and I suspect most IoT gateways). I have followed up in #208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum requirements for a TDD
4 participants