Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the External TD representations section #122

Closed
benfrancis opened this issue Nov 8, 2021 · 2 comments
Closed

Consider removing the External TD representations section #122

benfrancis opened this issue Nov 8, 2021 · 2 comments

Comments

@benfrancis
Copy link
Member

Originally proposed in #78

I propose removing the current External TD representations section because there is nothing in this section which isn't already defined in the Thing Description specification. These normative statements do not need repeating for the Core Profile and doing so risks the two specifications getting out of sync in the future.

benfrancis added a commit to benfrancis/wot-profile that referenced this issue Nov 9, 2021
@mlagally
Copy link
Contributor

The canonical section in the TD spec is likely to be removed from the 1.1 version.
This has been discussed in recent main / editors calls.

In this case the Canonicalisation section in the Profile needs to be preserved to make the existing protocol binding descriptions, that currently require the canonical form, work. Alternatively these descriptions could be simplified and have a direct description of how to resolve the form URL.

This is the preferred approach, so if we want to pursue this MR, please also change the binding sections..

@benfrancis
Copy link
Member Author

@mlagally wrote:

The canonical section in the TD spec is likely to be removed from the 1.1 version.
This has been discussed in recent main / editors calls.
In this case the Canonicalisation section in the Profile needs to be preserved to make the existing protocol binding descriptions, that currently require the canonical form, work.

If that's the reason then the current definition of a canonical TD in the WoT Profile would not be sufficient. The JSON Canonicalization Scheme is only one part of the process described in the canonicalisation process section of the Thing Description specification. The important part was that defaults should be made explicit. However...

Alternatively these descriptions could be simplified and have a direct description of how to resolve the form URL.

This is the preferred approach, so if we want to pursue this MR, please also change the binding sections..

This has already been done, there's no mention of canonical TDs in the protocol binding any more.

mlagally added a commit that referenced this issue Nov 11, 2021
Remove External TD representations section - closes #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants