incorporating accepted requirements #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlagally
requested review from
ashimura,
chachamimm,
mmccool,
sebastiankb and
mryuichi
benfrancis
suggested changes
Feb 23, 2022
There was a problem hiding this comment.
The content is fine (except for typos and one bad example).
However, as with my feedback on the use cases PR I can't find other examples of W3C specifications with the requirements for the specification included in the specification text itself. I suggest the requirements should be stored in the GitHub repository in a REQUIREMENTS.md file (or a separate Use Cases & Requirements document).
| <ul> | ||
| <li>Implementation complexity on a thing and consumer, e.g. eliminating the need of RDF processing, | ||
| but still permitting semantic annotations.</li> | ||
| <li>simplifying thing description to have less variations.</li> |
| <li>Implementation complexity on a thing and consumer, e.g. eliminating the need of RDF processing, | ||
| but still permitting semantic annotations.</li> | ||
| <li>simplifying thing description to have less variations.</li> | ||
| <li>limiting the effort for JSON implementation.</li> |
Comment on lines
+514
to
+515
| individually only satisfies one profile. For example, a Smart Building may need to use both "home" devices and | ||
| "industrial" devices. A gateway consuming TDs should be able to ingest TDs designed for both the home and industrial |
There was a problem hiding this comment.
"home" vs. "industrial" devices is a bad example, please remove or change (e.g. to constrained vs. unconstrained).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff