Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing next() in ThingDiscovery #177

Closed
zolkis opened this issue Jul 15, 2019 · 1 comment
Closed

Consider changing next() in ThingDiscovery #177

zolkis opened this issue Jul 15, 2019 · 1 comment

Comments

@zolkis
Copy link
Contributor

zolkis commented Jul 15, 2019

In the TAG review of WoT Architecture there were couple of comments on Scripting API as well.

This issue tracks the comment that the next() method in ThingDiscovery resembles an async iterator: either use iterators or change the name?

Option A: keep using next() and add an editor's note that while this resembles async iterators, it is not actually based on them, due to constrained implementations.

Option B: change the name for next() to avoid confusions.

Option C: actually use async iterators.

@zolkis
Copy link
Contributor Author

zolkis commented Jul 22, 2019

On the Scripting call on 22. July 2019 we agreed on Option A from above, i.e. to keep the next() method and done property at ThingDiscovery without making it an Iterable for time being, until understanding the impact on constrained implementations.

@zolkis zolkis closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant