-
Notifications
You must be signed in to change notification settings - Fork 28
Update text and examples regarding the fetching of TDs #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content-wise LGTM
see comment below about quotes...
Call 04/12/2023:
Group decision: rework the rationale removed by mentioning the use cases for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we need to keep the (reworked) fetch and validate section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to change it into an assertion (?)
Call 11/12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my part, we can deal with improving the section 5 vs appendix A in a new issue and merge this PR.
Call 15/01:
|
In the current Editor's draft, there are a couple of leftovers from previous versions where the
requestThingDescription
had not been introduced yet. This PR updates the text, incorporates the latest changes, and also removes an outdated appendix that explains why there is no fetch method anymore (which has now de facto been reintroduced). Maybe some text regarding the validation of TDs could be added/moved elsewhere, though.Preview | Diff