-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce profile term into TD model #1121
Conversation
@@ -93,7 +93,7 @@ | |||
is applied to TD instances."""^^rdf:HTML ; | |||
sh:datatype xsd:anyURI ; | |||
sh:maxCount 1 ; | |||
sh:order 8 ; | |||
sh:order 9 ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This change is unrelated but I noticed afterwards follows yet another sh:property
without sh:order
and the one after that one starts with sh:order 10
;
It seems to be that we might need to add sh:order
always and shift the numbers of the others? Am I wrong?
from today's TD call we decided to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
I agree with this change, I just might have worded the description slightly differently.
@@ -1128,7 +1128,8 @@ <h2>Core Vocabulary Definitions</h2> | |||
<tr class="rfc2119-table-assertion" id="td-vocab-securityDefinitions--Thing"><td><code>securityDefinitions</code></td><td>Set of named security configurations | |||
(definitions only). Not actually applied unless | |||
names are used in a <code>security</code> | |||
name-value pair.</td><td>mandatory</td><td><a>Map</a> of <a href="#securityscheme"><code>SecurityScheme</code></a></td></tr></tbody></table><p><span class="rfc2119-assertion" id= | |||
name-value pair.</td><td>mandatory</td><td><a>Map</a> of <a href="#securityscheme"><code>SecurityScheme</code></a></td></tr> | |||
<tr class="rfc2119-table-assertion" id="td-vocab-profile--Thing"><td><code>profile</code></td><td>Indicates the WoT Profile mechanisms followed by this Thing Description and the corresponding Thing implementation.</td><td>optional</td><td><a href="http://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/#anyURI"><code>anyURI</code></a> or <a>Array</a> of <a href="http://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/#anyURI"><code>anyURI</code></a></td></tr></tbody></table><p><span class="rfc2119-assertion" id= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The profile member doesn't indicate a profile mechanism followed by a Thing Description, it is a mechanism inside a Thing Description to indicate that the Web Thing it describes conforms to a particular profile or profiles.
Therefore I probably would have worded this slightly differently, e.g. "Indicates a profile or list of profiles to which the Web Thing conforms". Ideally with a link to the WoT Profile specification, if we can do that at this point.
Also see #806 and w3c/wot-profile#79
Preview | Diff