-
Notifications
You must be signed in to change notification settings - Fork 39
Manifest feature request: for tests that could be manual or reftest, support a preference for reftests #196
Comments
We should find a way to fix this as it's making harder to import tests and run them automatically into Blink. If the suggestion from @qyearsley is not good enough. Another option would be to fix the tests by changing the flags removing
For example, in some tests that require focus we've a small JavaScript that focus the element, but we still have them marked as Pinging some people with more experience on CSS test suite to check what they think about this: @fantasai, @frivoal, @gsnedders. Thanks! |
There were a bunch of tests that have both a reference file and the "interact" flag. They use some small JavaScript to execute some steps before checking the output against reference file. This caused them to be wrongly considered manual tests when they can be run automatically. For more info check w3c/wpt-tools#196 and w3c/wpt-tools#197.
There were a bunch of tests that have both a reference file and the "interact" flag. They use some small JavaScript to execute some steps before checking the output against reference file. This caused them to be wrongly considered manual tests when they can be run automatically. For more info check w3c/wpt-tools#196 and w3c/wpt-tools#197.
There were a bunch of tests that have both a reference file and the "interact" flag. They use some small JavaScript to execute some steps before checking the output against reference file. This caused them to be wrongly considered manual tests when they can be run automatically. For more info check w3c/wpt-tools#196 and w3c/wpt-tools#197.
For example the test css/css-writing-modes-3/background-position-vrl-018.xht contains the following:
Because of the "interact" flag, the manifest generator now considers this to be a manual test, even though it could also be a reference test.
Might we want to change the behavior of the manifest to treat this as a reftest, or provide an option to treat it as a reftest?
Changing it to always treat such tests as reftests when possible would be an easy, simple change; it would just involve changing the order of the elif blocks at SourceFile.manifest_items
More context: http://crbug.com/706953
The text was updated successfully, but these errors were encountered: