Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new information item for progression direction. #142

Merged
merged 3 commits into from
Mar 1, 2018

Conversation

iherman
Copy link
Member

@iherman iherman commented Feb 19, 2018

Fixes issue #126


Preview | Diff

@laudrain
Copy link

LGTM !

@dauwhe
Copy link
Contributor

dauwhe commented Feb 26, 2018

As @BigBlueHat mentioned on the call, there are only two values for page progression direction. Within HTML resources, CSS does allow for overflow in both x and y axes. If a publication resource scrolls "down," it might be a better reading experience for the next resource to appear below. Do we need a "top to bottom" direction?

@iherman
Copy link
Member Author

iherman commented Feb 26, 2018

@dauwhe, better discuss this on #126, because this PR is really only a write-up of the discussion and conclusion that happened there...

(I will copy this issue over there, just to save you time...)

@ghost
Copy link

ghost commented Feb 26, 2018

How about set default direction to "Reading System can choose default direction" which is same as idpf defined in http://www.idpf.org/epub/30/spec/epub30-publications.html#sec-spine-elem? It mightbe convenient when we need to convert from idpf to web infoset.

Totally agree with adding the new information item

…ogression

* 'master' of https://github.com/w3c/wpub:
  Change orcid img to a text label until rendering can be resolved
  fix unclosed dl list
  Added the WP address as a requirement in our WebIDL
  Linking issues to affordances' sections

# Conflicts:
#	index.html
@iherman
Copy link
Member Author

iherman commented Mar 1, 2018

@rakutenjeff : I am fine with what you propose and happy to do it if we have a consensus on the PR overall...

@mattgarrish
Copy link
Member

My take is we merge this PR and continue to work out any additional details in separate issues, so that's what I'll do. :)

Nothing is written in stone yet.

@mattgarrish mattgarrish merged commit fab2013 into master Mar 1, 2018
@mattgarrish mattgarrish deleted the resource-progression branch March 1, 2018 13:19
@ghost
Copy link

ghost commented Mar 1, 2018

Thanks @iherman Do you mind if I record it as a new issue since this is merged? Beside the default progression I was hoping wpub could have consistency with epub. And further more, my image of relationship between wpub and epub is wpub define what should be in manifest (and maybe define json serialization as well), and epub address those manifest items in packaged wp (epub) domain. So the manifest should be compatible. One of benefit is current publisher who already has millions of epubs would be easy to step into WP stage in the future.

@iherman
Copy link
Member Author

iherman commented Mar 1, 2018

@rakutenjeff of course, by all means! Please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants