Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility tweaks #337

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Accessibility tweaks #337

merged 3 commits into from
Sep 26, 2018

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Sep 25, 2018 •
edited by pr-preview bot
Loading

This PR fixes the following issues:

  • adds a recommendation to use the wiki vocabulary to the infoset section, with requirement not to omit unknown values
  • fixes accessModeSufficient to expect one or more ItemLists
  • corrects the example title and sufficient sets to better match the access modes
  • updates the manifest processing to remove the parts about stripping unknown values as discussed in clarify property names #336 (comment)

Preview | Diff

@mattgarrish
add recommendation to use preferred vocabulary for accessibility prop…
86a589c 
…erties, update accessmodedsufficient to ItemList, fix accessmodesufficient example, and delete step to remove unrecognized values
@mattgarrish
fix example json
943b911
@mattgarrish
whitespace tweak
f2fc429
@iherman iherman merged commit acf678d into master Sep 26, 2018
@iherman iherman deleted the accessibility-vocab branch September 26, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iherman iherman iherman approved these changes

@avneeshsingh avneeshsingh avneeshsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattgarrish @iherman @avneeshsingh