Re-do "waiting for all" #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #45.
ricea
reviewed
Sep 10, 2018
| 1. <a>Resolve</a> |promise| with |stepsResult|. | ||
| 1. Let |failureStepsWrapper| be the following steps, given |reason|: | ||
| 1. Let |stepsResult| be the result of performing |failureSteps| given |reason|. If these steps threw an exception, <a>reject</a> |promise| with that exception. | ||
| 1. <a>Resolve</a> |promise| with |stepsResult|. |
There was a problem hiding this comment.
Nah. If failureSteps return something, we resolve with that thing. If they throw we reject on the previous line.
annevk
reviewed
Sep 10, 2018
| To <dfn id="waiting-for-all" export lt="wait for all|waiting for all">wait for all</dfn> of a <a>list</a> of promises |promises|, with success steps |successSteps| that take a <a>list</a> of JavaScript values and failure steps |failureSteps| that take a rejection reason JavaScript value, perform the following steps: | ||
|
|
||
| 1. Let |rejectionHandler| be a built-in function that takes an argument |arg| and performs the following steps: | ||
| 1. Perform |failureSteps| given |arg|. |
There was a problem hiding this comment.
What's wrong with the indentation?
ricea
reviewed
Sep 11, 2018
| To <dfn id="waiting-for-all" export lt="wait for all|waiting for all">wait for all</dfn> of a <a>list</a> of promises |promises|, with success steps |successSteps| that take a <a>list</a> of JavaScript values and failure steps |failureSteps| that take a rejection reason JavaScript value, perform the following steps: | ||
|
|
||
| 1. Let |rejectionHandler| be a built-in function that takes an argument |arg| and performs the following steps: | ||
| 1. Perform |failureSteps| given |arg|. |
There was a problem hiding this comment.
If multiple promises reject, then failureSteps will be performed multiple times. Is this intentional?
There was a problem hiding this comment.
No, good catch. This was a no-op in Promise.all, because the failure steps there are just to reject a promise, and rejecting multiple times does nothing. Here it is bad. I will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45.
/cc @ricea @annevk.
I don't know if I'll have time to update all the dependencies that would be broken by this change. I think the most prominent user is https://w3c.github.io/ServiceWorker/.