Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calamar milestone 3 delivery #1077

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

uiii
Copy link
Contributor

@uiii uiii commented Dec 7, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1163

@PieWol
Copy link
Member

PieWol commented Dec 14, 2023

I'd like to do an external evaluation. @semuelle

@uiii
Copy link
Contributor Author

uiii commented Dec 22, 2023

Hi guys, I understand you might have too much work these days, but may I ask you when I can expect the evaluation?

@semuelle
Copy link
Member

Hey @uiii, sorry for the wait. I'll discuss this with @PieWol, who wanted to do the evaluation. I think this would still be the best option as most of the grants team is ooo for the holidays, but I'll get back to you with more info asap.

@PieWol
Copy link
Member

PieWol commented Dec 23, 2023

Hey @uiii ,
here is the link to my external evaluation PR. I have two aspects that hinder this delivery for approval. Looking forward to your response to the issues I raised.

@uiii
Copy link
Contributor Author

uiii commented Dec 24, 2023

Hi @PieWol, merry Christmas and thanks for the evaluation, here is my response to the issues:

  1. Show related runtime metadata in item's detail

I agree that metadata docs in spec 100001 is not so helpful, but parsing it and linking to the relevant sources it out of the scope of the current milestone. We just display what is present in the spec's metadata. As you can see, the polkadot-js documentation shows the same: https://polkadot.js.org/docs/polkadot/extrinsics#balances

image

We can improve it in the future, but right know I don't have a strightforward solution.

  1. building and testing output

Critical vulnerabilities are in webpack and @babel/travers package, there are the transitive dependencies of react-scripts and we use the latest version.

  1. trying to run locally with "npm start" as given in the readme

I cannot reproduce the error. I tried Windows cmd and also WSL. Which OS do you use? Try to update to the latest NodeJs version (LTS 20.x).

@PieWol
Copy link
Member

PieWol commented Dec 27, 2023

Hey @uiii, I have been busy for the holidays.

regarding 3. I'm using node v21.2.0 on Mac with ARM. I will try the latest LTS version as you suggested and get back to you.
For the metadata issue I would like to wait for feedback by @semuelle .

Hope you had a wonderful Christmas.

@uiii
Copy link
Contributor Author

uiii commented Dec 27, 2023

Hi @PieWol,
you can also try the docker option, it should work on every platform.

Thanks, enjoy Christmas too.

@PieWol
Copy link
Member

PieWol commented Dec 31, 2023

hey @uiii ,
I managed to get it working by removing the package lock and reinstalling all packages again. To profit from the standardization I used the docker image for testing. All 174 tests passed.

% npm run test                          

> calamar@0.1.0 test
> playwright test


Running 174 tests using 1 worker
  174 passed (4.3m)

Furthermore I thought about the metadata issue I complained about. Given that you are supporting so many networks I get it, that it's not in the scope of this grant to individually care for any metadata deviation.

With the tests passing and the metadata issue being outside of the scope of this grant, I see this as accepted.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uiii. I have verified the evaluation. I didn't have any issues with testing locally. I also noticed that the Polkadot data is a couple of days old, but I assume you have good reasons to fix this asap. One minor issue I would suggest to change is to make the tooltip when hovering over the extrinsic name clickable also. I kept clicking the text, not realizing that the icon is clickable only. Also, linking to a search of the extrinsic name from the extrinsic name isn't quite intuitive.

In any case, your milestone is hereby accepted (see evaluation notes here). Congrats on completing the grant and best of luck going forward!

@semuelle semuelle merged commit accf02b into w3f:master Jan 2, 2024
6 checks passed
Copy link

github-actions bot commented Jan 2, 2024

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

github-actions bot commented Jan 2, 2024

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@uiii
Copy link
Contributor Author

uiii commented Jan 3, 2024

Thank you, the invoice is sent.

@RouvenP
Copy link

RouvenP commented Jan 12, 2024

hi @uiii we just sent the payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants