-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calamar milestone 3 delivery #1077
Conversation
I'd like to do an external evaluation. @semuelle |
Hi guys, I understand you might have too much work these days, but may I ask you when I can expect the evaluation? |
Hi @PieWol, merry Christmas and thanks for the evaluation, here is my response to the issues:
I agree that metadata docs in spec 100001 is not so helpful, but parsing it and linking to the relevant sources it out of the scope of the current milestone. We just display what is present in the spec's metadata. As you can see, the We can improve it in the future, but right know I don't have a strightforward solution.
Critical vulnerabilities are in
I cannot reproduce the error. I tried Windows cmd and also WSL. Which OS do you use? Try to update to the latest NodeJs version (LTS 20.x). |
Hi @PieWol, Thanks, enjoy Christmas too. |
hey @uiii ,
Furthermore I thought about the metadata issue I complained about. Given that you are supporting so many networks I get it, that it's not in the scope of this grant to individually care for any metadata deviation. With the tests passing and the metadata issue being outside of the scope of this grant, I see this as accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @uiii. I have verified the evaluation. I didn't have any issues with testing locally. I also noticed that the Polkadot data is a couple of days old, but I assume you have good reasons to fix this asap. One minor issue I would suggest to change is to make the tooltip when hovering over the extrinsic name clickable also. I kept clicking the text, not realizing that the icon is clickable only. Also, linking to a search of the extrinsic name from the extrinsic name isn't quite intuitive.
In any case, your milestone is hereby accepted (see evaluation notes here). Congrats on completing the grant and best of luck going forward!
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
Thank you, the invoice is sent. |
hi @uiii we just sent the payment |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1163