Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solang Playground M3 eval #1204

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

ditavia-br
Copy link
Contributor

No description provided.

@salaheldinsoliman
Copy link
Contributor

@ditavia-br Hello 👋
1- Scope:
As per this conversation: w3f/Grants-Program#1894 (comment) , We've agreed that this milestone functionality shall focus on forwarding the user to the Contracts UI rather than implementing the interactions inside the frontend. This is mainly because we don't want to duplicate code, as well as Contracts UI is now really well established.

2- Testing coverage:
The language server, conforming most of the codebase, is adapted from the Hypereldger Solang repo. It is taken as is.
It is on our plans to improve the language server itself, but not at this time period. The focus is instead shifted on the frontend/backend applications and hosting them for easy access. Basically, get an MVP in place.

3- UI:
You are absolutely correct about the UI part; it still needs tons of improvements.
We have a dedicated milestone for that, milestone 4.

Does that answer your questions?

@semuelle semuelle marked this pull request as ready for review August 13, 2024 10:45
@semuelle semuelle self-assigned this Aug 13, 2024
@keeganquigley
Copy link
Contributor

Thanks @ditavia-br for your eval, much appreciated. I was also able to compile and instantiate contracts on the playground both locally and on the deployed version. Happy to pass it.

@keeganquigley keeganquigley merged commit 1156e78 into w3f:master Aug 26, 2024
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@RouvenP
Copy link

RouvenP commented Sep 6, 2024

hi @salaheldinsoliman we sent the payment today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants