Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faceless-milestone2.md #655

Merged
merged 5 commits into from
Dec 23, 2022
Merged

Faceless-milestone2.md #655

merged 5 commits into from
Dec 23, 2022

Conversation

HeisenbergLin22
Copy link
Contributor

@HeisenbergLin22 HeisenbergLin22 commented Dec 12, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#963 < please fill this in with the PR number of your application.

@alxs
Copy link
Contributor

alxs commented Dec 12, 2022

Thanks for the delivery @HeisenbergLin22. We'll look into it as soon as possible. In the meantime, could you please:

  • Make sure you're creating a new file for your delivery instead of modifying the template
  • Read your first comment above and tick all checkboxes that apply
  • Check your Dockerfile - the build is failing for me: docker.txt

@HeisenbergLin22
Copy link
Contributor Author

HeisenbergLin22 commented Dec 13, 2022

Thanks for the delivery @HeisenbergLin22. We'll look into it as soon as possible. In the meantime, could you please:

  • Make sure you're creating a new file for your delivery instead of modifying the template
  • Read your first comment above and tick all checkboxes that apply
  • Check your Dockerfile - the build is failing for me: docker.txt

Hey @alxs , thanks for your comments. I have already created a new file for the delivery and ticked the necessary checkboxes.

@HeisenbergLin22
Copy link
Contributor Author

HeisenbergLin22 commented Dec 13, 2022

Thanks for the delivery @HeisenbergLin22. We'll look into it as soon as possible. In the meantime, could you please:

  • Make sure you're creating a new file for your delivery instead of modifying the template
  • Read your first comment above and tick all checkboxes that apply
  • Check your Dockerfile - the build is failing for me: docker.txt

We have also updated the Dockerfile. Please take a look and see whether it works for you now.

@alxs
Copy link
Contributor

alxs commented Dec 13, 2022

Thanks. Could you please also fill out the invoice form and merge my PR? Someone else will look into your delivery again soon and test the Dockerfile.

Revert milestone delivery template
@HeisenbergLin22
Copy link
Contributor Author

Thanks. Could you please also fill out the invoice form and merge my PR? Someone else will look into your delivery again soon and test the Dockerfile.

Hey @alxs , already filled the invoice form and merged your pr. I look forward to the comments from you guys. Thx.

@0xCaso 0xCaso self-assigned this Dec 13, 2022
@alxs
Copy link
Contributor

alxs commented Dec 13, 2022

@HeisenbergLin22 could you also move the delivery file into the deliveries folder?

@HeisenbergLin22
Copy link
Contributor Author

@HeisenbergLin22 could you also move the delivery file into the deliveries folder?

Sure, done.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 14, 2022

Thanks @alxs for the fixes, and hi @HeisenbergLin22. I'm starting the evaluation, I'll write here if I need your help.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 14, 2022

@HeisenbergLin22 before I publish my evaluation, I'd like to ask you if with "Client Modules", in the delivery, you mean the functions you included in the faceless pallet. Am I wrong, or is the difference between milestones 1 and 2 ""just"" the newly added functions in /faceless-substrate-node/pallets/faceless/src/lib.rs, with the relative front-end part? Am I missing anything else?

@HeisenbergLin22
Copy link
Contributor Author

@HeisenbergLin22 before I publish my evaluation, I'd like to ask you if with "Client Modules", in the delivery, you mean the functions you included in the faceless pallet. Am I wrong, or is the difference between milestones 1 and 2 ""just"" the newly added functions in /faceless-substrate-node/pallets/faceless/src/lib.rs, with the relative front-end part? Am I missing anything else?

Hey @0xCaso , you are exactly right. The main difference is the newly added functions in /faceless-substrate-node/pallets/faceless/src/lib.rs, with the relative front-end part, which is how we defined the milestone 2 delivery in our original proposal.

Copy link
Contributor

@0xCaso 0xCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HeisenbergLin22 for the confirm. I've just pushed my evaluation here. Let me know if you have any question!

@HeisenbergLin22
Copy link
Contributor Author

Thanks @HeisenbergLin22 for the confirm. I've just pushed my evaluation here. Let me know if you have any question!

Thanks for your comments. Will get back to you on this soon.

@HeisenbergLin22
Copy link
Contributor Author

Thanks @HeisenbergLin22 for the confirm. I've just pushed my evaluation here. Let me know if you have any question!

Hey @0xCaso , thanks for your evaluation. You can find our response to your evaluation in this document. Please let me know if you have any further questions.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 19, 2022

Thanks a lot @HeisenbergLin22 for the changes and updates!
Everything looks pretty good. The only thing is that I can't register an account in the application, because during the registration phase I cannot select the right Country/Region for the phone number. Is there a way to bypass this?

@HeisenbergLin22
Copy link
Contributor Author

Thanks a lot @HeisenbergLin22 for the changes and updates! Everything looks pretty good. The only thing is that I can't register an account in the application, because during the registration phase I cannot select the right Country/Region for the phone number. Is there a way to bypass this?

Hey @0xCaso , thanks for your prompt response. Since this is a proof of concept, we don't provide the option of country/region code at the moment. But we will definitely take this into account in the next phase of product development. Thanks for your advice.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 20, 2022

I was meaning that in the section of the screenshot I'm not able to choose my country because it does not appear, so I can't go on with the testing of the dapp:
Screenshot 2022-12-20 at 09 14 06
So, is there a way to bypass this problem?

@HeisenbergLin22
Copy link
Contributor Author

I was meaning that in the section of the screenshot I'm not able to choose my country because it does not appear, so I can't go on with the testing of the dapp: Screenshot 2022-12-20 at 09 14 06 So, is there a way to bypass this problem?

Oh, I see. Would you please try to choose the country code that is already on the list, say the American one, and then type a random mobile number? We haven't worked out the challenge and response system yet since it's not on the delivery list. All you need to do after typing the mobile number step is to type a random four-number code and pass the authentication step. That should allow you to register the mobile number successfully.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 20, 2022

Thanks. I've just tried, but actually it doesn't work: after inserting the 4 numbers code, it comes back to the first registration page (with the "Add New Account" button)

@HeisenbergLin22
Copy link
Contributor Author

Thanks. I've just tried, but actually it doesn't work: after inserting the 4 numbers code, it comes back to the first registration page (with the "Add New Account" button)

Can you see the mobile number you input in the new HRI list? If it does appear in the updated list, then it means the registration is successful.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 20, 2022

Actually no, it does not appear. I've just the @hellohuman account, but I guess I can try to use that one

@HeisenbergLin22
Copy link
Contributor Author

HeisenbergLin22 commented Dec 20, 2022

here

I see, would you please confirm that you have run a local substrate node before starting to test the Faceless DApp as specified in this link? You have to successfully run a local node before testing the registration and other functions.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 20, 2022

For now I was trying with the deployed dapp, but I'll also try this part locally to check if it works here

@0xCaso
Copy link
Contributor

0xCaso commented Dec 20, 2022

Update: I managed to register an account locally (also if it disappears if the session is destroyed). However, I'm not able to try the functionalities (transfer, deposit and withdraw). I've tried with different tokens and amounts.

The thing is that the frontend was not a required delivery, so I cannot ask you to fix these things from a frontend perspective, but I can ask you to show me how to test them from the substrate-contract-node frontend (playing with extrinsics).

So before writing the next version of the evaluation, I'd like to know if I'm doing something wrong with the frontend

@HeisenbergLin22
Copy link
Contributor Author

HeisenbergLin22 commented Dec 20, 2022

link

Any chance you could be more specific about how the test of, say deposit fails? Like the token amount under the chosen HRI does not update after the deposit? This is important for us to know which steps went wrong.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 20, 2022

For example, deposit function:

  • I select the new registered user;
  • I select Deposit;
  • in the new page, instead of showing my tag, it shows @hellohuman; btw, I select DOT and put 1 as Amount (also in this page is not clear from where do the funds come, as I'm connected with an Ethereum wallet but below it's shown the Polkadot address...), and press Deposit;
  • it comes back to the previous page, History tab is loading but nothing happens.

@HeisenbergLin22
Copy link
Contributor Author

HeisenbergLin22 commented Dec 20, 2022

For example, deposit function:

  • I select the new registered user;
  • I select Deposit;
  • in the new page, instead of showing my tag, it shows @hellohuman; btw, I select DOT and put 1 as Amount (also in this page is not clear from where do the funds come, as I'm connected with an Ethereum wallet but below it's shown the Polkadot address...), and press Deposit;
  • it comes back to the previous page, History tab is loading but nothing happens.

Hey @0xCaso , would you please confirm you have successfully run the local nodes? None of the problems you mentioned occurred during our own test. Maybe we can schedule a meeting to show you how these functions work? Please add my Element handle @hlin100:matrix.org so that we can schedule a meeting there. You can also send an email to my gmail: lornacrevelingwgo23@gmail.com. We can also schedule a meeting via email. Thx

@0xCaso
Copy link
Contributor

0xCaso commented Dec 20, 2022

I'm sorry but I didn't see there was an error with the node, and it stopped producing blocks for some reason, you were right (maybe further on you could add something that tells that the dapp is not connected to a node). I'll try to see if I can reproduce the bug.

In the end, I managed to try Register, Deposit and Withdraw. With Transfer, the dapp reloads losing its current state values (and deleting the account previously created). To reproduce:

  • Go to Transfer;
  • Select Mobile Phone;
  • Press Next;
  • Select a Coin and put an Amount, then select Mobile Phone and press Transfer.

@HeisenbergLin22
Copy link
Contributor Author

HeisenbergLin22 commented Dec 21, 2022

I'm sorry but I didn't see there was an error with the node, and it stopped producing blocks for some reason, you were right (maybe further on you could add something that tells that the dapp is not connected to a node). I'll try to see if I can reproduce the bug.

In the end, I managed to try Register, Deposit and Withdraw. With Transfer, the dapp reloads losing its current state values (and deleting the account previously created). To reproduce:

  • Go to Transfer;
  • Select Mobile Phone;
  • Press Next;
  • Select a Coin and put an Amount, then select Mobile Phone and press Transfer.

Hey @0xCaso , thanks for your info. It seems you might have skipped a step in between "Select Mobile Phone" and "Press Next;", which is about inputting the receiver's user name and mpk (plz check the fig below). I have forgotten to mention this step in our current tutorial. Sorry about that. You can find the mpk on the downside of the webpage and you could use your own registered user name as the receiver, say, a mobile number like +1-352786901.
image

@0xCaso
Copy link
Contributor

0xCaso commented Dec 21, 2022

Hey @0xCaso , thanks for your info. It seems you might have skipped a step in between "Select Mobile Phone" and "Press Next;", which is about inputting the receiver's user name and mpk (plz check the fig below). I have forgotten to mention this step in our current tutorial. Sorry about that. You can find the mpk on the downside of the webpage and you could use your own registered user name as the receiver, say, a mobile number like +1-352786901.
image

Actually i didnt skip it, it seemed to be not relevant as whatever input I insert, I'll always see the same user as receiver of the transfer.

@HeisenbergLin22
Copy link
Contributor Author

Hey @0xCaso , thanks for your info. It seems you might have skipped a step in between "Select Mobile Phone" and "Press Next;", which is about inputting the receiver's user name and mpk (plz check the fig below). I have forgotten to mention this step in our current tutorial. Sorry about that. You can find the mpk on the downside of the webpage and you could use your own registered user name as the receiver, say, a mobile number like +1-352786901.
image

Actually i didnt skip it, it seemed to be not relevant as whatever input I insert, I'll always see the same user as receiver of the transfer.

Would you please confirm that the receiver account you input has been registered beforehand? Thx.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 22, 2022

Would you please confirm that the receiver account you input has been registered beforehand? Thx.

I've retried inserting a registered account, but as I already said nothing changes: I keep see @Teatrrrraloo as receiver. I don't know if it's because of the MPK value (I can't understand what it is); are you able to see the right receiver?

@HeisenbergLin22
Copy link
Contributor Author

link

Hey @0xCaso , you've actually successfully completed the transfer process. Please ignore @Teatrrrraloo, which is merely a placeholder. Please go ahead and click on "confirm". You won't receive any message after you click on "confirm". But if you go back to check your own account balance and also the receiver balance, you will find both have been updated accordingly. If you need more information on how transfer works, you could check the updated readme. Feel free to leave me a message if there is any other problem.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 23, 2022

Thanks a lot for the Tutorial update. Following the described steps, I was able to complete the transfer. I'm updating the evaluation!

@0xCaso 0xCaso mentioned this pull request Dec 23, 2022
@Noc2 Noc2 merged commit 2be663f into w3f:master Dec 23, 2022
@0xCaso
Copy link
Contributor

0xCaso commented Dec 23, 2022

I'm happy to let you know that the milestone 2 has been accepted, congrats!

Could you please resend the invoice with the VAT amount (that should be 0)?

@HeisenbergLin22
Copy link
Contributor Author

I'm happy to let you know that the milestone 2 has been accepted, congrats!

Could you please resend the invoice with the VAT amount (that should be 0)?

Thanks a lot. Already updated the invoice. Please check if the latest invoice works for you.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 23, 2022

Thanks a lot. Already updated the invoice. Please check if the latest invoice works for you.

The invoice you've sent is identical to the first one (that we received on 13 Dec - same date, no VAT amount)

@HeisenbergLin22
Copy link
Contributor Author

Thanks a lot. Already updated the invoice. Please check if the latest invoice works for you.

The invoice you've sent is identical to the first one (that we received on 13 Dec - same date, no VAT amount)

Sorry, might have updated it with the old file. The new invoice should have the updated date and the right VAT amount (right under Amount). Please check it out.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 23, 2022

The date is changed, but still the only amount (visible in the PDF you've sent) is 20k DAI for the milestone, there isn't the VAT one

@HeisenbergLin22
Copy link
Contributor Author

The date is changed, but still the only amount (visible in the PDF you've sent) is 20k DAI for the milestone, there isn't the VAT one

I see. I've updated the invoice, which includes another two lines for VAT amount and the total amount respectively. Thx.

@0xCaso
Copy link
Contributor

0xCaso commented Dec 23, 2022

Thanks a lot, this time it should be perfect. I'm forwarding it internally, so please allow up to 14 days for the payment process.

@RouvenP
Copy link

RouvenP commented Jan 9, 2023

hi @HeisenbergLin22, we transferred the payment today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants