-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create xcNFT.md #2358
Create xcNFT.md #2358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dudo50. Thanks for the application. I like it and I'll happily share it with the rest of the committee. That being said, have you talked to Unique about their pallet and plans beyond? Based on the timeline in their treasury proposal, they are still working on XCM NFT, so it might make sense to align. They even published a plan to create an NFT Collective to align work across ecosystem players.
EDIT: One thing: can you clarify who the benefactor of the grant will be? The team name at the top is Paraspell, but the legal details give a different name with no address.
Hey @semuelle , We haven't been in contact with the Unique team. While we believe, that the NFT Collective is a good initiative, we still believe, that more solid XCM NFT pallet options are viable for the ecosystem. Our solution adds many UX improvements and useful features on top of what xNFT currently offers extending the possibilities further. We also wish for our solution to be fully curated by the community once it is ready and we also had an idea of creating a collective where Parachains could vote on what should and shouldn't be added to the pallet. After the pallet is fully developed, this project could also become part of NFT Collective where Parachain teams will directly curate the next features as we originally planned, making the process simpler for us and the community. We will get in touch with the Unique team about this matter later on once the major part of work is done. As for the benefactor/legal entity/business that is stated in the application: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your approval @semuelle . We will fill out this form as soon as possible. I will ping you about the completion of KYB afterwards. |
Hey @semuelle , The KYB form has been filled out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to go ahead with it.
Hello there, I'm a core dev from the Unique Network team. As I can see, your proposal mainly highlights two issues: 1) the lack of adoption of cross-chain NFTs in the Polkadot ecosystem I want to leave my comments on both of the matters. AdoptionFirst, there's nothing really to adopt if we speak about Substrate-based tools. We did make a generalized version of the PoC pallet. Our current Substrate solution is in the review stage. We are developing a general solution so that everyone can benefit from cross-chain NFTs regardless of the particular NFT implementation they have on their chain. This is the reason why XCM functionality is separated from NFT engines. Moreover, our solution aligns with the existing XCM framework from theoretical and practical perspectives.
Your proposal doesn't fit into the existing XCM framework. I see you're using Even if you were using the teleports, you'd still need to provide a custom data communication system (again, using the At this moment, we focused on the reserve-based model since it is the most general way of transferring entities between chains without inducing trust between the communicating parties. There are use cases for NFT reserve-based transfers even without metadata operations. For details, see my Sub0 presentation. UX
There is no need to wait since the XCM interface already supports NFTs. How to implement this interface on-chain is an implementation detail. We are in the final stages of developing our "Simple XCM" TypeScript library. It supports every XCM version transparently to users, estimates total fees on all communicating chains (thanks to the XcmPaymentApi by Unique Network and the XCM DryRunApi by Parity), reports descriptive errors if found, and provides a registry of XCM locations and currencies (+ the registry can be modified dynamically). Thanks to the provided registry, the library user can use descriptive names for locations (accounts, chains, asset IDs, etc.) instead of relying on XCM Locations directly. Moreover, the library supports both pallet-xcm and pallet-xtokens. Hovewer, there is an extra issue regrding Asset Trapping: we want to have a clear way to rescue NFT assets if they are trapped regardless of fee estimation. Our accepted XCM RFC "Custom Asset Claimer" solves this. ConclusionI believe you can use the tools we are developing and build something on top of it. Our abstract Substrate solution takes into account that a collection can be viewed as an asset, for example. So, you can implement your vision of transferring whole collections across chains. I would like to propose that we collaborate to maintain and improve the upcoming "Simple XCM" library. Our goal is for this library to be maintained by the community, rather than just by us. It would be fantastic if we could work on this together as members of the NFT Collective. Another thing we can work on together is developing and refining educational materials around the XCM NFT stack. The Treasury covers these activities as part of our grant. Footnotes
|
@mrshiposha , thanks for finding time to respond to this Grant proposal PR. We appreciate it as it adds to the discussion. We agree with you about the following:
Our vision towards the future is to enhance and support such unique use cases - as that is where the power of NFTs shines and unlocks the ability to introduce unique niche projects to the ecosystem. We believe, that this isn't correctly understood from your side:
The solution you were looking at is our PoC solution - Demo. Think of it as the PoC your team delivered to the Karura. This solution will look completely different after refactoring and feature implementation. While it isn't meant to be directly implemented into SDK like the solution you propose it brings another perspective (Like the one you proposed in your PoC, but better in abstraction of complex details. Eg. PolkadotXCM (SDK) vs xTokens (3rd party implementation)). While we agree with you, that it isn't fully universal, it off-lifts maintenance requirements on SDK proposed by your Substrate solution. This allows our/other teams to release/implement updates/bug fixes faster without having to rely on a third party (Some updates in SDK can take a while to be merged as the amount of code is insane and maintenance needed to keep everything up requires lots of effort from multiple people within Parity team (For which we think they are heroes in many ways).
This isn't new. We already offer everything you mentioned at ParaSpell for quite a while now in both XCM SDK & XCM API.
Could you explain what the benefits of having collections viewed as an asset are?
We would suggest you to check what ParaSpell XCM libraries currently offer. We believe we offer the best UX abstraction from XCM for developers on the market. Perhaps forces could rather be joined to perfect already existing fully open-source XCM Tools at ParaSpell and further increase XCM adoption in the ecosystem. Let us know what you think. |
@dudo50 Thanks for the clarification.
We aim to create something simple to maintain and use with solid fee estimation mechanisms (using the new Runtime APIs). The XCM SDK you mentioned looks similar in idea, but it is more comprehensive than the simple library we want to create.
Looking at your PoC, I noticed that you've added support for cross-chain transfers of collections ( |
@mrshiposha No worries!
That would be brilliant and we are more than open to it! We have been looking to improve the fee mechanism for a while now. Having more precise fee calculation would be a great benefit for all three of our XCM tools (XCM SDK, XCM API & mainly XCM Router). Here is my telegram handle - Dudo50 feel free to contact me and we can establish a ParaSpell<>Unique telegram group where we can cooperate on this matter.
Thanks for clear explanation. We agree, that this could be beneficial for the user. However as the functionality is not yet present(merged) we will try to implement it our way first to see, if we can come up with another solution that makes sense and is user friendly (Because we have something in mind for this). However, in the future, once your solution is merged, we are more than happy to replace the mechanism if it will outperform what we designed. Looking forward to hearing from you on telegram in regards to the fee estimation package. |
cc @takahser , Any news regarding the status of the review? With kind regards, |
@dudo50 thx for pinging and sorry for the delay. I'm planning to give you feedback by tomorrow EOD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dudo50 thanks for the updates and the patience. Also big thx to @mrshiposha for your contribution and the offer to collab regarding a optimized fee estimation library. Happy to add my approval here as well.
@keeganquigley could you confirm if kyc/b has been successfully completed before we merge this?
Hi @dudo50 what name did you submit for KYB under? I'm not finding anything under ParaSpell Research Foundation? |
Hey @keeganquigley , Under business name mentioned in the proposal: Michael Absolon |
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Hey @dudo50 , we have released a dev environment to play with the NFT XCM as it will go into production, see here for instructions: https://gist.github.com/mrshiposha/42797eff799b33e7e1599665638330d2 |
Thanks @am-uniquenetwork , we will have a look on it asap! Could you leave us your telegram where we could reach you guys? Thanks! |
@NFTXCM is a channel, just set it up |
Could you send us an invite link? Or you can directly invite me, and I will invite my colleague: nick - Dudo50 |
… On Fri, Sep 27, 2024, 3:36 PM Dusan Morhac ***@***.***> wrote:
Could you send us invite link? Or you can directly invite me and I will
invite my colleague - Dudo50
—
Reply to this email directly, view it on GitHub
<#2358 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLUW2X3ANK7XIUOWIJPL5D3ZYVNMNAVCNFSM6AAAAABMAXO67KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGMYDGMZQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* Create xcNFT.md * Update xcNFT.md * Update xcNFT.md
Project Abstract
xcNFT is a common good pallet/substrate module meant to enhance the cross-chain experience and bring real adoption to cross-chain non-fungible asset sharing in Polkadot and Kusama ecosystems.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)