Proposal changes #583

MilGard91 · 2021-08-18T10:08:37Z

Project Abstract

This is a update for previous grant PR.

Application Checklist

The application template has been copied, renamed ( project_name.md) and updated.
A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
I have read and acknowledged the terms and conditions.
The software delivered for this grant will be released under an open-source license specified in the application.
The initial PR contains only one commit (squash and force-push if needed).
The grant will only be announced once the first milestone has been accepted.

CLAassistant · 2021-08-18T10:08:41Z

All committers have signed the CLA.

alxs · 2021-08-18T10:56:12Z

Thanks @MilGard91. Could you please also adjust the price to account for the missing functionality and sign the CLA?

MilGard91 · 2021-08-19T08:11:00Z

Hi @alxs, price is adjusted and I signed the CLA.

alxs · 2021-08-20T10:52:30Z

applications/substrate-identity-directory.md

@@ -87,8 +84,7 @@ We have experience in several private and open source projects aswell as project
 | 2. | Design an individual identity page | Create design mockups in Figma. |
 | 3. | Implement list page | Build UI components in VueJS used in the identity list page. | 
 | 4. | Implement individual identity page | Build UI components in VueJS used in the individual identity page. 
-| 5. | Implement query logic for identity data | Implement query logic which will be used to retrieve identity data. |  
-| 6. | Query identity activities | Implement query logic which will be used to retrieve activities indicative of a member’s reputation. |  


Could you move this to a different milestone instead, together with the treasury and governance modules? Feel free to distribute the price across the two milestones as you think fit.

I have created Milestone 3 out of that deliverable. @alxs

To clarify, I meant you may split the price of this milestone (which previously contained all deliverables) between this and the new milestone.

alxs · 2021-08-23T10:08:07Z

applications/substrate-identity-directory.md

@@ -87,8 +84,7 @@ We have experience in several private and open source projects aswell as project
 | 2. | Design an individual identity page | Create design mockups in Figma. |
 | 3. | Implement list page | Build UI components in VueJS used in the identity list page. | 
 | 4. | Implement individual identity page | Build UI components in VueJS used in the individual identity page. 
-| 5. | Implement query logic for identity data | Implement query logic which will be used to retrieve identity data. |  
-| 6. | Query identity activities | Implement query logic which will be used to retrieve activities indicative of a member’s reputation. |  


To clarify, I meant you may split the price of this milestone (which previously contained all deliverables) between this and the new milestone.

alxs · 2021-08-23T10:13:39Z

applications/substrate-identity-directory.md

+
+| Number | Deliverable | Specification |
+| ------------- | ------------- | ------------- |
+| 1. | Index data from nodes | Setup [substrate-archive](https://github.com/paritytech/substrate-archive) with postgres for Polkadot and Kusama chains to store required data |


We also only fund deliverables that may be useful to others in the ecosystem, i.e. we can't support you in integrating existing software.

I am not sure if I understand. This backend infrastructure is a requirement for governance & treasury data to be retrieved.

alxs · 2021-08-23T10:16:02Z

applications/substrate-identity-directory.md

 ## Future Plans

-After finishing milestones 1 and 2 users can utilize the basic application which supports querying by address, index or identity fields. Application has a list page and a single page view with a basic info column fully functional. Users will be able to set their own node endpoint.
+After finishing milestones 1 and 2 users can utilize the basic application which supports querying by address. Application has a list page and a single page view with a basic info column fully functional. Users will be able to set their own node endpoint.


Why did you remove this? Seems like a very useful feature to me.

Accidentally. I have reverted that now.

DeFiYaco · 2021-08-23T10:38:08Z

@alxs I have just contacted Kuba to schedule another meeting, so we can solve this faster.

alxs · 2021-08-24T12:54:12Z

applications/substrate-identity-directory.md

+* https://github.com/paritytech/substrate-archive/issues/97
+* https://github.com/paritytech/substrate-archive/issues/111
+* https://github.com/paritytech/substrate-archive/issues/132 


These are different PRs from the one you mentioned in your previous email, could you please explain? And do you care to elaborate on how this is blocking you exactly? Polkascan for example have implemented pretty much this exact functionality https://polkascan.io/kusama/account/EGVQCe73TpFyAZx5uKfE1222XfkT3BSKozjgcqzLBnc5eYo

I have added the missing PR to the list. To be able to retrieve and decode extrinsics from older blocks, this PR and issues must be merged and solved. Those three issues on substrate-archive are related to type-decoding.
Also, this is the response we got from the official discord server:
"At what blocks are you not getting any traces? State tracing is only supported on runtime versions v8.27 and above, so if you are on a block height below that runtime version then you will not get any traces. For runtime v0.9.XX a release is being cut to include support for those runtime versions today or tomorrow."
That is still not live in the latest version.
As agreed on the call, let's proceed with the payment for the first two milestones as they are delivered and not connected to the current issue. Thank you for your input about polkascan, we will research milestone 3 on their method for retrieving the missing data.

I would rather suggest you look into this now as it was (and still is as long as the amendment hasn't been accepted) part of the deliverables for milestone 1. As far as I'm aware, Polkascan are open source and just using their harvester might do.

Nevertheless, I will share with the rest of the committee.

Payment for the first two milestones will be made when the review has been completed.

Btw: Subscan also provides this functionality https://polkadot.subscan.io/account/EGVQCe73TpFyAZx5uKfE1222XfkT3BSKozjgcqzLBnc5eYo?tab=extrinsic

semuelle

I think the identity activities are the most important and useful part of the project, so I would suggest to split the price between M1 and M3 60:40, rather than the 92:8 split you are proposing. As far as I can see, the archive issues currently holding you back are already being worked on?

DeFiYaco · 2021-08-30T10:39:28Z

I think the identity activities are the most important and useful part of the project, so I would suggest to split the price between M1 and M3 60:40, rather than the 92:8 split you are proposing. As far as I can see, the archive issues currently holding you back are already being worked on?

I agree. I have updated the cost ratio between M1 and M3

semuelle · 2021-08-30T12:32:48Z

You did not update the cost ratio, you just raised the total price. What makes you think we would support raising the price by more than a third without any extra deliverables?

edisinovcic · 2021-08-30T13:16:25Z

You did not update the cost ratio, you just raised the total price. What makes you think we would support raising the price by more than a third without any extra deliverables?

You propose that we reduce the price of the first and second milestone vs third in 60:40 so that first 2 milestones are worth 20700$ and the 3rd milestone is worth 13800$?

semuelle · 2021-08-30T13:41:28Z

You propose that we reduce the price of the first and second milestone vs third in 60:40 so that first 2 milestones are worth 20700$ and the 3rd milestone is worth 13800$?

Since M2 is unchanged, I would leave its price as is, but shift more of the payment from M1 to M3.

DeFiYaco · 2021-08-30T14:01:34Z

You propose that we reduce the price of the first and second milestone vs third in 60:40 so that first 2 milestones are worth 20700$ and the 3rd milestone is worth 13800$?

Since M2 is unchanged, I would leave its price as is, but shift more of the payment from M1 to M3.

Updated.

alxs

I'm happy to approve this, however I don't know how likely it is the functionality discussed above will be added to subtrate-archive any time soon, so I encourage you to consider alternative solutions.

* Proposal changes * milestone 3 added * Updating proposal with required changes * updated costs Co-authored-by: Jakov Buratovic <kraljipo007@gmail.com> Co-authored-by: Edi Sinovcic <edi.sinovcic@gmail.com>

MilGard91 mentioned this pull request Aug 18, 2021

substrate identity directory #255

Merged

6 tasks

Noc2 added the changes requested The team needs to clarify a few things first. label Aug 19, 2021

Proposal changes

afc033f

MilGard91 force-pushed the master branch from 660a6a6 to afc033f Compare August 19, 2021 08:05

alxs added the amendment This PR proposes changes to an existing application. label Aug 20, 2021

alxs suggested changes Aug 20, 2021

View reviewed changes

alxs suggested changes Aug 23, 2021

View reviewed changes

milestone 3 added

028f671

DeFiYaco force-pushed the master branch from 9bb46b8 to 028f671 Compare August 23, 2021 10:21

alxs reviewed Aug 24, 2021

View reviewed changes

Updating proposal with required changes

14ccb08

DeFiYaco force-pushed the master branch from e2ccff9 to 14ccb08 Compare August 25, 2021 08:37

alxs added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Aug 26, 2021

semuelle requested changes Aug 27, 2021

View reviewed changes

updated costs

35113ae

DeFiYaco force-pushed the master branch from fae5d6b to 35113ae Compare August 30, 2021 13:59

semuelle approved these changes Aug 30, 2021

View reviewed changes

alxs approved these changes Sep 7, 2021

View reviewed changes

mmagician approved these changes Sep 7, 2021

View reviewed changes

mmagician merged commit 4969227 into w3f:master Sep 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposal changes #583

Proposal changes #583

MilGard91 commented Aug 18, 2021

CLAassistant commented Aug 18, 2021 •

edited

Loading

alxs commented Aug 18, 2021

MilGard91 commented Aug 19, 2021

alxs Aug 20, 2021

DeFiYaco Aug 23, 2021

alxs Aug 23, 2021

alxs Aug 23, 2021

alxs Aug 23, 2021

DeFiYaco Aug 23, 2021

alxs Aug 23, 2021 •

edited

Loading

DeFiYaco Aug 23, 2021

DeFiYaco commented Aug 23, 2021

alxs Aug 24, 2021

DeFiYaco Aug 25, 2021

alxs Aug 26, 2021

alxs Aug 26, 2021

semuelle left a comment

DeFiYaco commented Aug 30, 2021

semuelle commented Aug 30, 2021

edisinovcic commented Aug 30, 2021

semuelle commented Aug 30, 2021

DeFiYaco commented Aug 30, 2021

alxs left a comment

Proposal changes #583

Proposal changes #583

Conversation

MilGard91 commented Aug 18, 2021

Project Abstract

Application Checklist

CLAassistant commented Aug 18, 2021 • edited Loading

alxs commented Aug 18, 2021

MilGard91 commented Aug 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alxs Aug 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeFiYaco commented Aug 23, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

semuelle left a comment

Choose a reason for hiding this comment

DeFiYaco commented Aug 30, 2021

semuelle commented Aug 30, 2021

edisinovcic commented Aug 30, 2021

semuelle commented Aug 30, 2021

DeFiYaco commented Aug 30, 2021

alxs left a comment

Choose a reason for hiding this comment

CLAassistant commented Aug 18, 2021 •

edited

Loading

alxs Aug 23, 2021 •

edited

Loading