Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Reserved for compact encoding" constant is incorrect #543

Closed
tomaka opened this issue Oct 5, 2022 · 2 comments
Closed

"Reserved for compact encoding" constant is incorrect #543

tomaka opened this issue Oct 5, 2022 · 2 comments
Assignees
@lamafab

Comments

@tomaka
Copy link
Collaborator

tomaka commented Oct 5, 2022

In the "node header" section (https://spec.polkadot.network/#defn-node-header), "Reserved for compact encoding" is defined as 0001000. In reality it's 00000001.

https://github.com/paritytech/trie/blob/aff1cbac8f03e8dc7533263b374dc0fcd17444ad/test-support/reference-trie/src/substrate_like.rs#L55
@cheme
Copy link

cheme commented Oct 5, 2022

I confirm.

@lamafab lamafab closed this as completed in 11c4b1a Oct 5, 2022
@FlorianFranzen FlorianFranzen assigned lamafab and unassigned bhargavbh Oct 5, 2022
@tomaka
Copy link
Collaborator Author

tomaka commented Oct 5, 2022

Note that the text below that talk about distinguishing this value from the other because the other 4 bits are zero doesn't really make sense anymore.

lamafab added a commit that referenced this issue Oct 5, 2022
@lamafab
remove deprecated sentence, context: #543
6212f2a
qdm12 added a commit to ChainSafe/gossamer that referenced this issue Dec 5, 2022
@qdm12
Fix compact node variant bits (see w3f/polkadot-spec#543)
c9c3462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lamafab lamafab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tomaka @cheme @bhargavbh @lamafab