Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state trie version to be as value instead of pointer-size #518

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Fix state trie version to be as value instead of pointer-size #518

merged 2 commits into from
Jul 21, 2022

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Jul 6, 2022

No description provided.

@tomaka
Copy link
Collaborator

tomaka commented Jul 13, 2022

If I'm not mistaken, the version is indeed not a pointer-size, but it's not a pointer either. It's simply a i32 that specifies the version, either 0 or 1.

@qdm12 qdm12 changed the title Fix state trie version to be as pointer instead of pointer-size Fix state trie version to be as direct value instead of pointer or pointer-size Jul 13, 2022
@qdm12
Copy link
Contributor Author

qdm12 commented Jul 13, 2022

I updated the changes so it's just the state version and no longer a pointer nor pointer-size.

@qdm12 qdm12 changed the title Fix state trie version to be as direct value instead of pointer or pointer-size Fix state trie version to be as value instead of pointer-size Jul 13, 2022
@qdm12 qdm12 mentioned this pull request Jul 13, 2022
Closed
10 tasks
@lamafab lamafab merged commit d9425d0 into w3f:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qdm12 @tomaka @lamafab