Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC/WIP] Spec version 3 of clear_prefix and kill_storage #592

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

lamafab
Copy link
Contributor

@lamafab lamafab commented Nov 25, 2022

Context: #588 (Not merging until the RFC has been finalized)

  • ext_storage_clear_prefix_version_3
  • ext_default_child_storage_clear_prefix_version_3
  • ext_default_child_storage_kill_storage_version_4

@lamafab
Copy link
Contributor Author

lamafab commented Feb 22, 2023

This is now implemented in the Substrate codebase.

@tomaka
Copy link
Collaborator

tomaka commented Feb 22, 2023

This is now implemented in the Substrate codebase.

Do you have a link to a PR? I can't find it.

If it's indeed been implemented, it arguably shouldn't have been without a RFC/discussion.

@lamafab
Copy link
Contributor Author

lamafab commented Feb 22, 2023

So I found this: paritytech/substrate#11490 Looks like it has been there for quite some time now 🤔

@bkchr
Copy link
Contributor

bkchr commented Feb 22, 2023

I also wanted to have this done as some RFC (I know that I very very slow). The current implementation isn't done in the way it was described in the issue in Substrate.

@tomaka
Copy link
Collaborator

tomaka commented Feb 22, 2023

So correct me if I'm wrong: this PR doesn't actually correspond to #588 (as mentioned in the OP) but corresponds to paritytech/substrate#11490, which has already been deployed ages ago?

@bkchr
Copy link
Contributor

bkchr commented Feb 22, 2023

which has already been deployed ages ago

We never activated the host functions, so it was never deployed. So, we can still fix them.

@lamafab
Copy link
Contributor Author

lamafab commented Feb 22, 2023

Reverted changes

@Noc2 Noc2 deleted the clear-prefix-changes branch September 8, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants