-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async backing parameters and fix image references #5524
Add async backing parameters and fix image references #5524
Conversation
cc @seadanda if you want to have a look also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Feel free to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -214,6 +214,22 @@ This phase consists of changes to your parachain’s runtime that activate async | |||
|
|||
![minimum-period](../assets/async/async-backing-minimum-period.png) | |||
|
|||
6. **Update parameters:** Once the runtime is deployed the final step is to update three parameters! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my case these had to be set on local relay to then propagate to parachain, so might be useful to explicitly mention that these are on the relay and only required for local testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, let me know if that's clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nicely done!
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Follow-up to #5506 with fixes.
Addition of final step is based on paritytech/polkadot-sdk#2236
cc @evilrobot-01 @darkfriend77