feat(openapi/explode): explicitly set false in specs #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Using
omitempty
with bool type ends up having the configuration not being set in openapi spec file.As default value for the
explode
configuration istrue
(see this page), when we want to set it to false, it is not defined in the spec file.Example reproducer based on this repository master branch:
json spec output:
As you can see, explode is missing in the
myQueryParam
parameter configuration, making it impossible to override it's default value which istrue
.When I set
explode:"true"
ininputModel
struct, spec file looks like this:With
true
, swagger will generate the following query parameter string:?myQueryParam=a&myQueryParam=b
, while when set itfalse
, it generates?myQueryParam=a,b
. Wherea
andb
are fake values formyQueryParam
.