This repository was archived by the owner on Mar 23, 2023. It is now read-only.
More patches for cakePHP 3 #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resque_Job_Creator cannot be in namespace CakeResque in order to be found by Resque_Job->getIntance; - so in CakeResqueBootstrap we `require Resque_Job_Creator.php` insetad of trying autoload with `use CakeResque/Resque_Job_Creator`; - self::$rootFolder correctly points to src - $model (Shell class) is now properly namespaced (App\Shell) - removed perform method search, replaced returning the method to invoke (runCommand) as well as the class instance as an array Removed bootstrap_config since CakePHP 3 no longer supports arrays of files as plugin bootstrap value (to init CakeResque with values different from defaults plugin must be loaded with no bootstrap enabled and then CakeResque::init must be called with the config values) Improved Exceptions messages: - explicit being thrown by Resque_Job_Creator - diffrentiate between file not found and class not found in file
- Resque_Job_Creator.php is no longer needed, Resque_Job_Creator is defined in CakeResqueBootstrap.php - Resque_Job_Creator does not need to inspect anything since everything is nicely handled by the Cake\Console\ShellDispatcher->dispatch method - the args list must mock the 0th element from cli (file name: 'void')
…e to locate CakePHP bootstrap itself - The Job will be run with the Cake Console switch -q to avoid cluttering log files
…Shell->stats it needs to look for the next job to be executed, "future" included.
oanhnn
pushed a commit
to rikkeisoft/Cake-Resque
that referenced
this pull request
Mar 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes I made to actually be able to let Jobs be correctly executed as CakePHP 3 Shells.
These goes together with the PR#34 on php-resque-ex
Main things: