Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Fix kill when user differs to process owner #40

Merged
merged 1 commit into from
Oct 22, 2014

Conversation

joeholdcroft
Copy link

When running Fresque on my Vagrant box with the user set to www-data but running the commands as vagrant, I noticed that the stop command did not work.

It didn't report an error, but it did not output the green "Done" text next to each stopped worker. The output looked something like:

----------------
Stopping workers
----------------
Workers list
  1) vagrant:8048:dispatched_orders, started 1 day and 2 hours ago
  2) vagrant:8039:new_orders, started 1 day and 2 hours ago
all) Stop all workers

Worker to stop: all
stopping 8048 ... 
stopping 8039 ... 

I copied some code for running the command as another user from the start method. It might want some abstraction to avoid the repetition, but I wasn't sure what other commands might be affected.

@leto
Copy link

leto commented Sep 9, 2014

👍 , I have run into this as well.

jadb added a commit to jadb/Fresque that referenced this pull request Oct 7, 2014
wa0x6e added a commit that referenced this pull request Oct 22, 2014
Fix kill when user differs to process owner
@wa0x6e wa0x6e merged commit 7a03a9e into wa0x6e:master Oct 22, 2014
@wa0x6e
Copy link
Owner

wa0x6e commented Oct 22, 2014

Thanks 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants