Additional UI changes to help user confusion and information #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added hard drive free space detection, added red error message text, removed overwrite checkbox, added wiki button link extended the error text for starting wabbajack in protected location removed debug code shortened error message to fit in text box
JanuarySnow
force-pushed
the
blocking_fixes
branch
from
13208c0
to
98c12d4
Compare
EzioTheDeadPoet
approved these changes
Jul 20, 2023
Aegis270
reviewed
Jul 26, 2023
…turn of the overwrite install checkbox
|
Added some code to revert the popup window warning about files existing in install path, as it was unwieldy and fired multiple times whenever validate() was called. Instead just added it as an error return type alongside all the other error types, so it prints the warning on the screen, and ive reintroduced the "overwrite installation" checkbox to make that warning go away and re-enable the play button. |
|
Duplicate of #2416 Technically the other one is the duplicate but I am trying to user Github trigger words to make it more fun. 😉 Edit: Well experiment failed so I'll just close this manually. And thank you for the contribution that will be merged on the other branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2372
Added a few more features to the UI to help ease support burden.
Added check that the install folder isnt inside the download folder
Removed the overwrite installation checkbox - it didnt save its state anymore as far as I can tell, and clicking it saved you one click by avoiding the "are you sure you want to overwrite?" prompt. - so clicking once to avoid one click isnt much of a good deal, and it caused user confusion as to its actual purpose.
I've added a hard drive space checker to the install and download paths, ( if same drive itll add the required download and install together ), and itll block the install if there isnt enough space
Ive added some red warning text under the file picker textbox, to additionally outline the current blocking error, so user does not need to be told "hover your mouse over warning label" to find out what the current error is.
Ive expanded the error message text for existing files in the chosen install path, to make it clear that if user is updating an existing modlist, then it is fine to continue.
Updated error message text for protected folders to be more clear about what a protected folder means, and what user might need to do to avoid targeting them
Ive added an additional button to the install failure screen, that links to the wabbajack wiki, so users might press it on an install failure and get some self-help
I have more comprehensive plans in this area, but I see this as more pressing in the meantime due to the number of support queries regarding these install blocking errors.
( self-conscious disclaimer - I am obviously still very new to ReactiveUI/WPF, and c# in general , coming from other languages I may not be aware of some common patterns, so apologies for the roughness of this - currently nobody else is stepping up to fix these things in the short-term, so I will, but I will gladly step back if somebody implements these things better )
Pictures here: