Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manual downloads sometimes launching in browser and related issues #2380

Closed
wants to merge 3 commits into from
Closed

Fix manual downloads sometimes launching in browser and related issues #2380

wants to merge 3 commits into from

Conversation

UrbanCMC
Copy link
Contributor

Fixes the following issues:

  • Downloads will no longer start in the webview browser, which could happen if the download started before navigation was completely finished.
  • Cookies that are stored under an abnormal domain name (e.g. www.example.org -> .example.org) are now correctly retrieved, preventing authentication issues.
  • Instead of a hard-coded user agent, the webview user agent is now passed on to the downloader, preventing authentication issues.

I've verified that this change doesn't negatively affect other websites that use manual downloads, like LL.

@EzioTheDeadPoet EzioTheDeadPoet mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UrbanCMC @EzioTheDeadPoet