A few LSP highlights are missing

[teleivo]

Hi 😄 I absolutely love this theme 😍 thank you so much!

I think there are some highlights for LSPs that are missing. Might be as neovim is still changing 😅

https://neovim.io/doc/user/lsp.html#lsp-highlight

LspReferenceText used for highlighting "text" references
LspReferenceRead used for highlighting "read" references
LspReferenceWrite used for highlighting "write" references
LspInlayHint used for highlighting inlay hints
LspCodeLens Used to color the virtual text of the codelens
LspCodeLensSeparator Used to color the separator between two or more code lenses
LspSignatureActiveParameter Used to highlight the active parameter in the signature help

I could help out with a PR but I don't know which colors would make sense 😅

I checked what other themes do for

• LspReferenceText
• LspReferenceRead
• LspReferenceWrite

For example, https://github.com/folke/tokyonight.nvim/blob/f247ee700b569ed43f39320413a13ba9b0aef0db/lua/tokyonight/theme.lua#L177-L179 uses the same config. I linked the highlight groups to Visual.

[wadackel]

Sorry I have not been able to reply!
I am busy right now and will check back later and reply 😭

[teleivo]

Sorry I have not been able to reply! I am busy right now and will check back later and reply 😭

No worries and no rush 😄

[wadackel]

@teleivo

Thank you for waiting!
I tried adjusting the style as shown in the following image, how do you feel about that? I tried applying a style similar to matchparen :)

I don't usually use document highlight, so I would appreciate any feedback 🐶
(This style has not been pushed yet)

[teleivo]

Thanks a lot, @wadackel that makes sense to me 😄 It draws less attention than Visual and since it's distinct from Visual I can tell the two apart 😁

[teleivo]

I found another LSP highlight group https://neovim.io/doc/user/lsp.html#hl-LspSignatureActiveParameter which might be great to add 😏.

It highlights the active parameter when using vim.lsp.buf.signature_help().

When linking it to Visual it looks like

[wadackel]

@teleivo

Thank you for your further suggestions 🐕

There are cases where styles are already applied depending on the library you use, so you don't want to break them. It is designed to tell the user the current edited part by using at least Italic style :)

I just pushed four style changes to the main branch 🐶

[teleivo]

Thanks a lot! Looking great 😄

The italic style is not as visible to me as for example Visual. I don't quite understand

There are cases where styles are already applied depending on the library you use, so you don't want to break them. It is designed to tell the user the current edited part by using at least Italic style :)

do you have an example of how linking LspSignatureActiveParameter to for example Visual could break a library 😅