test: Support to more common -update flag

doc/TODO.md

@@ -58,7 +58,7 @@
 
 ### Tests
 
-- WRITE_ACTUAL does not preserve comment order for readlines
+- update tests does not preserve comment order for readlines
 - empty file test
 - CLI tests, raw write, colors?
 - Interactive tests

doc/dev.md

@@ -41,7 +41,7 @@ Flags can be struct with bit-fields.
   - If possible use a pair of `testdata/file` and `testdata/file.fqtest` where `file.fqtest` is `$ fq dv file` or `$ fq 'dv,torepr' file` if there is `torepr` support.
   - If `dv` produces a lof of output maybe use `dv({array_truncate: 50})` etc
   - Run `go test ./format -run TestFormats/<name>` to test expected output.
-  - Run `WRITE_ACTUAL=1 go test ./format -run TestFormats/<name>` to write current output as expected output.
+  - Run `go test ./format -run TestFormats/<name> -update` to update current output as expected output.
 - If you have format specific documentation:
   - Put it in `format/*/<name>.md` and use `//go:embed <name>.md`/`interp.RegisterFS(..)` to embed/register it.
   - Use simple markdown, just sections (depth starts at 3, `### Section`), paragraphs, lists and links.
@@ -236,10 +236,10 @@ make test
 go test ./...
 # run all tests for one format
 go test -run TestFormats/mp4 ./format/
-# write all actual outputs
-WRITE_ACTUAL=1 go test ./...
-# write actual output for specific tests
-WRITE_ACTUAL=1 go run -run ...
+# update all actual outputs in tests
+go test ./... -update
+# update actual output for specific tests
+go run ./format -run TestFormats/elf -update
 # color diff
 DIFF_COLOR=1 go test ...
 ```

format/fqtest_test.go

@@ -1,13 +1,16 @@
 package format_test
 
 import (
+	"flag"
 	"testing"
 
 	_ "github.com/wader/fq/format/all"
 	"github.com/wader/fq/pkg/fqtest"
 	"github.com/wader/fq/pkg/interp"
 )
 
+var update = flag.Bool("update", false, "Update tests")
+
 func TestFormats(t *testing.T) {
-	fqtest.TestPath(t, interp.DefaultRegistry)
+	fqtest.TestPath(t, interp.DefaultRegistry, *update)
 }

format/tzif/testdata/generate_fqtest.sh

@@ -45,7 +45,7 @@ tear_down() {
       echo "$ fq -d tzif dv $f" > "$of"
     done
 
-  WRITE_ACTUAL=1 go test -run TestFQTests/tzif "$d/../.."
+  go test -run TestFQTests/tzif "$d/../.." -update
   if grep "error" ./*.fqtest; then
     exit 1
   fi

format/wasm/testdata/core/generate_fqtest.sh

@@ -42,7 +42,7 @@ tear_down() {
       echo "$ fq -d wasm dv $f" > "$of"
     done
 
-  WRITE_ACTUAL=1 go test -run TestFQTests/wasm "$d/../../.."
+  go test -run TestFQTests/wasm "$d/../../.." -update
   if grep "error" ./*.fqtest; then
     exit 1
   fi

pkg/fqtest/fqtest.go

@@ -11,12 +11,12 @@ import (
 	"github.com/wader/fq/pkg/interp"
 )
 
-func TestPath(t *testing.T, registry *interp.Registry) {
+func TestPath(t *testing.T, registry *interp.Registry, update bool) {
 	difftest.TestWithOptions(t, difftest.Options{
 		Path:        ".",
 		Pattern:     "*.fqtest",
 		ColorDiff:   os.Getenv("DIFF_COLOR") != "",
-		WriteOutput: os.Getenv("WRITE_ACTUAL") != "",
+		WriteOutput: os.Getenv("WRITE_ACTUAL") != "" || update,
 		Fn: func(t *testing.T, path, input string) (string, string, error) {
 			t.Parallel()
 

pkg/interp/fqtest_test.go

@@ -1,13 +1,16 @@
 package interp_test
 
 import (
+	"flag"
 	"testing"
 
 	_ "github.com/wader/fq/format/all"
 	"github.com/wader/fq/pkg/fqtest"
 	"github.com/wader/fq/pkg/interp"
 )
 
+var update = flag.Bool("update", false, "Update tests")
+
 func TestInterp(t *testing.T) {
-	fqtest.TestPath(t, interp.DefaultRegistry)
+	fqtest.TestPath(t, interp.DefaultRegistry, *update)
 }