mp4,ctts: Seem more usable to treat sample count/offset as signed

Seems to different between specs Modify avc.fqtest to generate a ctts box
wader · Dec 20, 2021 · eb9698f · eb9698f
1 parent e1e8a23
commit eb9698f
Show file tree

Hide file tree

Showing 3 changed files with 406 additions and 322 deletions.
diff --git a/format/mp4/boxes.go b/format/mp4/boxes.go
@@ -601,8 +601,8 @@ func init() {
 			entryCount := d.FieldU32("entry_count")
 			var i uint64
 			d.FieldStructArrayLoop("entries", "entry", func() bool { return i < entryCount }, func(d *decode.D) {
-				d.FieldU32("sample_count")
-				d.FieldU32("sample_offset")
+				d.FieldS32("sample_count")
+				d.FieldS32("sample_offset")
 				i++
 			})
 		},