midi: fixed lint warning (cf. #1004 (comment))

wader · Aug 28, 2024 · f424936 · f424936
1 parent 462ae15
commit f424936
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/format/midi/midi.go b/format/midi/midi.go
@@ -163,14 +163,15 @@ func peekEvent(d *decode.D) (uint64, uint8, uint8) {
 	}
 }
 
+// Big endian varint
 func vlq(d *decode.D) uint64 {
 	vlq := uint64(0)
 
 	for {
 		b := d.U8()
 
 		vlq <<= 7
-		vlq += uint64(b & 0x7f)
+		vlq += b & 0x7f
 
 		if b&0x80 == 0 {
 			break
@@ -180,6 +181,7 @@ func vlq(d *decode.D) uint64 {
 	return vlq
 }
 
+// Variable length with a big endian varint length
 func vlf(d *decode.D) ([]uint8, error) {
 	N := int(vlq(d))
 
@@ -190,6 +192,7 @@ func vlf(d *decode.D) ([]uint8, error) {
 	}
 }
 
+// Variable length string with a big endian varint length
 func vlstring(d *decode.D) string {
 	if data, err := vlf(d); err != nil {
 		d.Errorf("%v", err)

diff --git a/format/midi/testdata/Makefile b/format/midi/testdata/Makefile
@@ -18,6 +18,9 @@ debug: build
 test: build
 	go test ./format -run TestFormats/midi
 
+lint: test
+	make -f Makefile lint
+
 regenerate: build
 	go test ./format -run TestFormats/midi -update